Mercurial > hg > orthanc-stone

changeset 1851:739a69562826

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Tue, 29 Jun 2021 14:25:58 +0200
parents 932dc2265baa
children 5ead1852095a cbb5c4a66160
files Applications/Resources/RunCppCheck.sh OrthancStone/Sources/Oracle/OracleCommandBase.h
diffstat 2 files changed, 11 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/Applications/Resources/RunCppCheck.sh	Tue Jun 29 14:09:54 2021 +0200
+++ b/Applications/Resources/RunCppCheck.sh	Tue Jun 29 14:25:58 2021 +0200
@@ -29,8 +29,8 @@
 
 cat <<EOF > /tmp/cppcheck-suppressions.txt
 stlFindInsert:../../Applications/Samples/WebAssembly/SingleFrameViewer/SingleFrameViewerApplication.h
-stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:387
-stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:982
+stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:485
+stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:1123
 unpreciseMathCall:../../OrthancStone/Sources/Scene2D/Internals/CairoFloatTextureRenderer.cpp
 unpreciseMathCall:../../OrthancStone/Sources/Scene2D/LookupTableTextureSceneLayer.cpp
 unreadVariable:../../OrthancStone/Sources/Viewport/SdlViewport.cpp:143
--- a/OrthancStone/Sources/Oracle/OracleCommandBase.h	Tue Jun 29 14:09:54 2021 +0200
+++ b/OrthancStone/Sources/Oracle/OracleCommandBase.h	Tue Jun 29 14:25:58 2021 +0200
@@ -47,8 +47,15 @@
 
     virtual Orthanc::IDynamicObject& GetPayload() const;
 
-    void SetCallerName(const std::string callerName) { callerName_ = callerName; }
-    virtual std::string GetCallerName() const { return callerName_; }
+    void SetCallerName(const std::string& callerName)
+    {
+      callerName_ = callerName;
+    }
+    
+    virtual std::string GetCallerName() const ORTHANC_OVERRIDE
+    {
+      return callerName_;
+    }
 
     Orthanc::IDynamicObject* ReleasePayload();
   };