# HG changeset patch # User Sebastien Jodogne # Date 1624969558 -7200 # Node ID 739a69562826f1166f86326653336a8494dce1da # Parent 932dc2265baafaf30c33e9db3126f8166eef20a5 cppcheck diff -r 932dc2265baa -r 739a69562826 Applications/Resources/RunCppCheck.sh --- a/Applications/Resources/RunCppCheck.sh Tue Jun 29 14:09:54 2021 +0200 +++ b/Applications/Resources/RunCppCheck.sh Tue Jun 29 14:25:58 2021 +0200 @@ -29,8 +29,8 @@ cat < /tmp/cppcheck-suppressions.txt stlFindInsert:../../Applications/Samples/WebAssembly/SingleFrameViewer/SingleFrameViewerApplication.h -stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:387 -stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:982 +stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:485 +stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:1123 unpreciseMathCall:../../OrthancStone/Sources/Scene2D/Internals/CairoFloatTextureRenderer.cpp unpreciseMathCall:../../OrthancStone/Sources/Scene2D/LookupTableTextureSceneLayer.cpp unreadVariable:../../OrthancStone/Sources/Viewport/SdlViewport.cpp:143 diff -r 932dc2265baa -r 739a69562826 OrthancStone/Sources/Oracle/OracleCommandBase.h --- a/OrthancStone/Sources/Oracle/OracleCommandBase.h Tue Jun 29 14:09:54 2021 +0200 +++ b/OrthancStone/Sources/Oracle/OracleCommandBase.h Tue Jun 29 14:25:58 2021 +0200 @@ -47,8 +47,15 @@ virtual Orthanc::IDynamicObject& GetPayload() const; - void SetCallerName(const std::string callerName) { callerName_ = callerName; } - virtual std::string GetCallerName() const { return callerName_; } + void SetCallerName(const std::string& callerName) + { + callerName_ = callerName; + } + + virtual std::string GetCallerName() const ORTHANC_OVERRIDE + { + return callerName_; + } Orthanc::IDynamicObject* ReleasePayload(); };