Mercurial > hg > orthanc-object-storage

changeset 233:b170a065c75f 2.5.2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
clarify warning messages in hybrid mode
author Alain Mazy <am@orthanc.team>
date Mon, 13 Apr 2026 10:55:59 +0200
parents d0d686f3a643
children c3d9b76f6d0a
files Common/StoragePlugin.cpp TODO
diffstat 2 files changed, 4 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/Common/StoragePlugin.cpp	Wed Apr 08 15:56:52 2026 +0200
+++ b/Common/StoragePlugin.cpp	Mon Apr 13 10:55:59 2026 +0200
@@ -168,7 +168,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(std::string(StoragePluginFactory::GetStoragePluginName()) + ": error while reading object " + std::string(uuid) + ": " + std::string(ex.what()));
+    logErrorFunction(storage->GetNameForLogs() + ": failed to read object " + std::string(uuid) + ": " + std::string(ex.what()));
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 }
@@ -261,7 +261,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(storage->GetNameForLogs() + ": error while reading object " + std::string(uuid) + ": " + ex.what());
+    logErrorFunction(storage->GetNameForLogs() + ": failed to read object " + std::string(uuid) + ": " + ex.what());
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 
@@ -327,7 +327,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(std::string(StoragePluginFactory::GetStoragePluginName()) + ": error while deleting object " + std::string(uuid) + ": " + std::string(ex.what()));
+    logErrorFunction(storage->GetNameForLogs() + ": failed to delete object " + std::string(uuid) + ": " + std::string(ex.what()));
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 }
--- a/TODO	Wed Apr 08 15:56:52 2026 +0200
+++ b/TODO	Mon Apr 13 10:55:59 2026 +0200
@@ -1,4 +1,4 @@
-- Remove false Error log when working in hybrid mode
+- Remove false Error log when working in hybrid mode (note: at least for S3, it now appears as a warning with the correct 'primary' or 'secondary' storage name)
   https://discourse.orthanc-server.org/t/object-storage-hybrid-mode/5218
 
 - Investigate use of soft-delete with Google Cloud Storage