# HG changeset patch
# User Alain Mazy <am@orthanc.team>
# Date 1776070559 -7200
# Node ID b170a065c75f36271a82109bed0f48d1c5c7daa0
# Parent  d0d686f3a643dac5bbcbfb833a1b6ca42395b104
clarify warning messages in hybrid mode

diff -r d0d686f3a643 -r b170a065c75f Common/StoragePlugin.cpp
--- a/Common/StoragePlugin.cpp	Wed Apr 08 15:56:52 2026 +0200
+++ b/Common/StoragePlugin.cpp	Mon Apr 13 10:55:59 2026 +0200
@@ -168,7 +168,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(std::string(StoragePluginFactory::GetStoragePluginName()) + ": error while reading object " + std::string(uuid) + ": " + std::string(ex.what()));
+    logErrorFunction(storage->GetNameForLogs() + ": failed to read object " + std::string(uuid) + ": " + std::string(ex.what()));
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 }
@@ -261,7 +261,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(storage->GetNameForLogs() + ": error while reading object " + std::string(uuid) + ": " + ex.what());
+    logErrorFunction(storage->GetNameForLogs() + ": failed to read object " + std::string(uuid) + ": " + ex.what());
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 
@@ -327,7 +327,7 @@
   }
   catch (StoragePluginException& ex)
   {
-    logErrorFunction(std::string(StoragePluginFactory::GetStoragePluginName()) + ": error while deleting object " + std::string(uuid) + ": " + std::string(ex.what()));
+    logErrorFunction(storage->GetNameForLogs() + ": failed to delete object " + std::string(uuid) + ": " + std::string(ex.what()));
     return OrthancPluginErrorCode_StorageAreaPlugin;
   }
 }
diff -r d0d686f3a643 -r b170a065c75f TODO
--- a/TODO	Wed Apr 08 15:56:52 2026 +0200
+++ b/TODO	Mon Apr 13 10:55:59 2026 +0200
@@ -1,4 +1,4 @@
-- Remove false Error log when working in hybrid mode
+- Remove false Error log when working in hybrid mode (note: at least for S3, it now appears as a warning with the correct 'primary' or 'secondary' storage name)
   https://discourse.orthanc-server.org/t/object-storage-hybrid-mode/5218
 
 - Investigate use of soft-delete with Google Cloud Storage