changeset 801:f9e4d92b0e97

cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Fri, 10 Apr 2026 18:42:44 +0200
parents 86555367e0e9
children f31f174d194b
files Framework/Common/DatabaseManager.cpp
diffstat 1 files changed, 7 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/Framework/Common/DatabaseManager.cpp	Fri Apr 10 18:40:26 2026 +0200
+++ b/Framework/Common/DatabaseManager.cpp	Fri Apr 10 18:42:44 2026 +0200
@@ -102,16 +102,16 @@
     
     std::unique_ptr<IPrecompiledStatement> statement(GetDatabase().Compile(query));
       
-    IPrecompiledStatement* tmp = statement.get();
-    if (tmp == NULL)
+    if (statement.get() == NULL)
     {
       throw Orthanc::OrthancException(Orthanc::ErrorCode_InternalError);
     }
-
-    assert(cachedStatements_.find(statementId) == cachedStatements_.end());
-    cachedStatements_[statementId] = statement.release();
-
-    return *tmp;
+    else
+    {
+      assert(cachedStatements_.find(statementId) == cachedStatements_.end());
+      cachedStatements_[statementId] = statement.release();
+      return *cachedStatements_[statementId];
+    }
   }