# HG changeset patch # User Sebastien Jodogne # Date 1775839364 -7200 # Node ID f9e4d92b0e97231ee06a63114a5aae961b9b5b6b # Parent 86555367e0e987a369d6689073fc23040e669a74 cppcheck diff -r 86555367e0e9 -r f9e4d92b0e97 Framework/Common/DatabaseManager.cpp --- a/Framework/Common/DatabaseManager.cpp Fri Apr 10 18:40:26 2026 +0200 +++ b/Framework/Common/DatabaseManager.cpp Fri Apr 10 18:42:44 2026 +0200 @@ -102,16 +102,16 @@ std::unique_ptr statement(GetDatabase().Compile(query)); - IPrecompiledStatement* tmp = statement.get(); - if (tmp == NULL) + if (statement.get() == NULL) { throw Orthanc::OrthancException(Orthanc::ErrorCode_InternalError); } - - assert(cachedStatements_.find(statementId) == cachedStatements_.end()); - cachedStatements_[statementId] = statement.release(); - - return *tmp; + else + { + assert(cachedStatements_.find(statementId) == cachedStatements_.end()); + cachedStatements_[statementId] = statement.release(); + return *cachedStatements_[statementId]; + } }