Mercurial > hg > orthanc

changeset 4485:f19de27a2465

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Thu, 28 Jan 2021 19:28:32 +0100
parents 64f06e7d5fc7
children 83a6a84ba9df
files OrthancFramework/Sources/RestApi/RestApi.cpp OrthancServer/Resources/RunCppCheck.sh
diffstat 2 files changed, 7 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/RestApi/RestApi.cpp	Thu Jan 28 19:03:19 2021 +0100
+++ b/OrthancFramework/Sources/RestApi/RestApi.cpp	Thu Jan 28 19:28:32 2021 +0100
@@ -137,7 +137,7 @@
 
     protected:
       virtual bool HandleCall(RestApiCall& call,
-                              const std::set<std::string> uriArgumentsNames) = 0;
+                              const std::set<std::string>& uriArgumentsNames) = 0;
   
     public:
       explicit DocumentationVisitor(RestApi& restApi) :
@@ -365,7 +365,7 @@
 
     protected:
       virtual bool HandleCall(RestApiCall& call,
-                              const std::set<std::string> uriArgumentsNames) ORTHANC_OVERRIDE
+                              const std::set<std::string>& uriArgumentsNames) ORTHANC_OVERRIDE
       {
         const std::string path = Toolbox::FlattenUri(call.GetFullUri());
 
@@ -683,7 +683,7 @@
 
     protected:
       virtual bool HandleCall(RestApiCall& call,
-                              const std::set<std::string> uriArgumentsNames) ORTHANC_OVERRIDE
+                              const std::set<std::string>& uriArgumentsNames) ORTHANC_OVERRIDE
       {
         Path& path = paths_[ Toolbox::FlattenUri(call.GetFullUri()) ];
 
--- a/OrthancServer/Resources/RunCppCheck.sh	Thu Jan 28 19:03:19 2021 +0100
+++ b/OrthancServer/Resources/RunCppCheck.sh	Thu Jan 28 19:28:32 2021 +0100
@@ -15,16 +15,16 @@
 nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:319
 nullPointerRedundantCheck:../../OrthancFramework/UnitTestsSources/DicomMapTests.cpp
 stlFindInsert:../../OrthancFramework/Sources/DicomFormat/DicomMap.cpp:1163
-stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:174
-stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:71
-stlFindInsert:../../OrthancServer/Sources/OrthancWebDav.cpp:384
+stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:164
+stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:72
+stlFindInsert:../../OrthancServer/Sources/OrthancWebDav.cpp:385
 stlFindInsert:../../OrthancServer/Sources/ServerIndex.cpp:400
 syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h:50
 syntaxError:../../OrthancFramework/UnitTestsSources/ZipTests.cpp:130
 syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:319
 uninitMemberVar:../../OrthancServer/Sources/ServerJobs/StorageCommitmentScpJob.cpp:427
 unreadVariable:../../OrthancFramework/Sources/FileStorage/StorageAccessor.cpp
-unreadVariable:../../OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp:784
+unreadVariable:../../OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp:1108
 unusedFunction
 useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:89
 useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:285