Mercurial > hg > orthanc

changeset 6487:d7bbe6dc90ba

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Tue, 25 Nov 2025 14:31:39 +0100
parents f44c708caf25
children 10784233f0e0
files OrthancFramework/Sources/DicomParsing/Internals/DicomFrameIndex.cpp OrthancFramework/Sources/Enumerations.h OrthancServer/Resources/RunCppCheck-2.17.1.sh
diffstat 3 files changed, 5 insertions(+), 13 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/DicomParsing/Internals/DicomFrameIndex.cpp	Tue Nov 25 14:24:48 2025 +0100
+++ b/OrthancFramework/Sources/DicomParsing/Internals/DicomFrameIndex.cpp	Tue Nov 25 14:31:39 2025 +0100
@@ -227,7 +227,7 @@
       }
     }
 
-    virtual uint8_t* GetRawFrameBuffer(unsigned int index)
+    virtual uint8_t* GetRawFrameBuffer(unsigned int index) ORTHANC_OVERRIDE
     {
       if (index >= startFragment_.size())
       {
@@ -300,11 +300,10 @@
       }
     }
 
-    virtual uint8_t* GetRawFrameBuffer(unsigned int index)
+    virtual uint8_t* GetRawFrameBuffer(unsigned int index) ORTHANC_OVERRIDE
     {
       return pixelData_ + index * frameSize_;
     }
-
   };
 
 
@@ -337,11 +336,10 @@
       }
     }
 
-    virtual uint8_t* GetRawFrameBuffer(unsigned int index)
+    virtual uint8_t* GetRawFrameBuffer(unsigned int index) ORTHANC_OVERRIDE
     {
       throw OrthancException(ErrorCode_NotImplemented);
     }
-
   };
 
 
--- a/OrthancFramework/Sources/Enumerations.h	Tue Nov 25 14:24:48 2025 +0100
+++ b/OrthancFramework/Sources/Enumerations.h	Tue Nov 25 14:31:39 2025 +0100
@@ -973,12 +973,6 @@
   DicomTransferSyntax GetTransferSyntax(const std::string& uid);
 
   ORTHANC_PUBLIC
-  bool IsRawTransferSyntax(DicomTransferSyntax syntax);
-
-  ORTHANC_PUBLIC
-  bool IsLossyTransferSyntax(DicomTransferSyntax syntax);
-
-  ORTHANC_PUBLIC
   const char* GetResourceTypeText(ResourceType type,
                                   bool isPlural,
                                   bool isUpperCase);
--- a/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Tue Nov 25 14:24:48 2025 +0100
+++ b/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Tue Nov 25 14:31:39 2025 +0100
@@ -17,7 +17,7 @@
 constParameterCallback:../../OrthancFramework/Sources/DicomNetworking/Internals/StoreScp.cpp:112
 constParameterCallback:../../OrthancFramework/Sources/DicomNetworking/Internals/StoreScp.cpp:113
 constParameterCallback:../../OrthancFramework/Sources/Pkcs11.cpp:125
-constParameterCallback:../../OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp:3489
+constParameterCallback:../../OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp:3493
 constParameterCallback:../../OrthancServer/Sources/OrthancGetRequestHandler.cpp:47
 constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:447
 constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:451
@@ -39,7 +39,7 @@
 knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2298
 knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2299
 knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2300
-nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:322
+nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:321
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:166
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:74
 syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h:53