Mercurial > hg > orthanc

changeset 7069:ce8dfabee759

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
clang-tidy
author Alain Mazy <am@orthanc.team>
date Wed, 12 Aug 2026 11:01:49 +0200
parents 0fedfdc07684
children c5e5774720fc
files OrthancFramework/Sources/DataSource/DataSourceAnswer.cpp OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp OrthancFramework/Sources/Logging.cpp OrthancServer/Plugins/Engine/OrthancPlugins.cpp
diffstat 4 files changed, 4 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/DataSource/DataSourceAnswer.cpp	Wed Aug 12 10:44:33 2026 +0200
+++ b/OrthancFramework/Sources/DataSource/DataSourceAnswer.cpp	Wed Aug 12 11:01:49 2026 +0200
@@ -54,7 +54,7 @@
   DataSourceAnswer::Item::Item(IDataIdentifier* id /* takes ownership */,
                                const OrthancException& error) :
     id_(id),
-    error_(new OrthancException(error)),
+    error_(new OrthancException(error)),  // NOLINT(bugprone-throw-keyword-missing)
     memorySize_(0)
   {
     if (id == NULL)
--- a/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp	Wed Aug 12 10:44:33 2026 +0200
+++ b/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp	Wed Aug 12 11:01:49 2026 +0200
@@ -4006,7 +4006,7 @@
             Uint64 f;
             if (content.getUint64(f, i).good())
             {
-              values.push_back(f);
+              values.push_back(static_cast<int64_t>(f));
 
               if (static_cast<Uint64>(values.back()) != f)
               {
--- a/OrthancFramework/Sources/Logging.cpp	Wed Aug 12 10:44:33 2026 +0200
+++ b/OrthancFramework/Sources/Logging.cpp	Wed Aug 12 11:01:49 2026 +0200
@@ -1573,7 +1573,7 @@
             {
               (*it)->HandleLog(level_, category_, pluginName_, file_, line_, messageStream_.str());
             }
-            catch (...)
+            catch (...) // NOLINT(bugprone-empty-catch)
             {
               // Don't throw in destructors
             }
--- a/OrthancServer/Plugins/Engine/OrthancPlugins.cpp	Wed Aug 12 10:44:33 2026 +0200
+++ b/OrthancServer/Plugins/Engine/OrthancPlugins.cpp	Wed Aug 12 11:01:49 2026 +0200
@@ -2581,7 +2581,7 @@
             cgroups_.resize(what.size() - 1);
             for (size_t i = 1; i < what.size(); i++)
             {
-              groups_[i - 1] = what[i];
+              groups_[i - 1] = what[static_cast<int>(i)];
               cgroups_[i - 1] = groups_[i - 1].c_str();
             }
           }