changeset 6215:c6ae4244f075

fix Toolbox::UriEncode(): the slash is a reserved character
author Sebastien Jodogne <s.jodogne@gmail.com>
date Mon, 30 Jun 2025 21:45:06 +0200
parents 3a974dbf4740
children e1bc2e729c1c
files OrthancFramework/Sources/Toolbox.cpp OrthancFramework/UnitTestsSources/FrameworkTests.cpp
diffstat 2 files changed, 2 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/Toolbox.cpp	Wed Jun 25 15:08:50 2025 +0200
+++ b/OrthancFramework/Sources/Toolbox.cpp	Mon Jun 30 21:45:06 2025 +0200
@@ -1482,8 +1482,7 @@
             c == '-' ||
             c == '_' ||
             c == '.' ||
-            c == '~' ||
-            c == '/');
+            c == '~');
   }
 
   void Toolbox::UriEncode(std::string& target,
--- a/OrthancFramework/UnitTestsSources/FrameworkTests.cpp	Wed Jun 25 15:08:50 2025 +0200
+++ b/OrthancFramework/UnitTestsSources/FrameworkTests.cpp	Mon Jun 30 21:45:06 2025 +0200
@@ -1278,7 +1278,7 @@
   Toolbox::UriEncode(s, t); 
   ASSERT_EQ(t, s);
 
-  Toolbox::UriEncode(s, "!#$&'()*+,/:;=?@[]"); ASSERT_EQ("%21%23%24%26%27%28%29%2A%2B%2C/%3A%3B%3D%3F%40%5B%5D", s);  
+  Toolbox::UriEncode(s, "!#$&'()*+,/:;=?@[]"); ASSERT_EQ("%21%23%24%26%27%28%29%2A%2B%2C%2F%3A%3B%3D%3F%40%5B%5D", s);
   Toolbox::UriEncode(s, "%"); ASSERT_EQ("%25", s);
 
   // Encode characters from UTF-8. This is the test string from the