Mercurial > hg > orthanc
changeset 6977:aacfa67e39ce
clarify unit test FromDcmtkBridge.ValueRepresentationConversions
| author | Sebastien Jodogne <s.jodogne@gmail.com> |
|---|---|
| date | Fri, 03 Jul 2026 11:32:09 +0200 |
| parents | 5b8ee3b407b1 |
| children | f54d6046149f |
| files | OrthancServer/UnitTestsSources/UnitTestsMain.cpp |
| diffstat | 1 files changed, 9 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/OrthancServer/UnitTestsSources/UnitTestsMain.cpp Thu Jul 02 17:33:14 2026 +0200 +++ b/OrthancServer/UnitTestsSources/UnitTestsMain.cpp Fri Jul 03 11:32:09 2026 +0200 @@ -164,21 +164,19 @@ } else { - bool skip = false; - #if DCMTK_VERSION_NUMBER < 361 if (i == ValueRepresentation_OtherDouble || i == ValueRepresentation_UnlimitedCharacters || i == ValueRepresentation_UniversalResource) { - skip = true; + continue; // Not supported in DCMTK < 3.6.1 } #endif #if DCMTK_VERSION_NUMBER < 362 if (i == ValueRepresentation_OtherLong) { - skip = true; + continue; // Not supported in DCMTK < 3.6.2 } #endif @@ -187,15 +185,17 @@ i == ValueRepresentation_SignedVeryLong || i == ValueRepresentation_UnsignedVeryLong) { - skip = true; + continue; // Not supported in DCMTK < 3.6.5 } #endif - if (!skip) + ASSERT_EQ(vr, FromDcmtkBridge::Convert(ToDcmtkBridge::Convert(vr))); + OrthancPluginValueRepresentation plugins = Plugins::Convert(vr); + ASSERT_EQ(vr, Plugins::Convert(plugins)); + + if (vr != ValueRepresentation_Unknown) { - ASSERT_EQ(vr, FromDcmtkBridge::Convert(ToDcmtkBridge::Convert(vr))); - OrthancPluginValueRepresentation plugins = Plugins::Convert(vr); - ASSERT_EQ(vr, Plugins::Convert(plugins)); + ASSERT_NE(OrthancPluginValueRepresentation_UN, plugins); } } }
