changeset 6743:7105e665441a

cppcheck
author Alain Mazy <am@orthanc.team>
date Thu, 07 May 2026 18:17:29 +0200
parents b9752ef08934
children 827f3c162824
files OrthancFramework/Sources/Logging.h OrthancServer/Resources/RunCppCheck-2.17.1.sh OrthancServer/Resources/RunCppCheck-2.20.0.sh
diffstat 3 files changed, 8 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/Logging.h	Thu May 07 16:52:02 2026 +0200
+++ b/OrthancFramework/Sources/Logging.h	Thu May 07 18:17:29 2026 +0200
@@ -78,7 +78,7 @@
     class ScopedThreadNameSetter
     {
     public:
-      ScopedThreadNameSetter(const std::string& threadName);
+      explicit ScopedThreadNameSetter(const std::string& threadName);
 
       ~ScopedThreadNameSetter();
     };
--- a/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Thu May 07 16:52:02 2026 +0200
+++ b/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Thu May 07 18:17:29 2026 +0200
@@ -23,7 +23,7 @@
 constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:452
 constParameterPointer:../../OrthancFramework/Sources/Toolbox.cpp:3343
 knownConditionTrueFalse:../../OrthancFramework/Sources/DicomNetworking/Internals/CommandDispatcher.cpp:112
-knownConditionTrueFalse:../../OrthancFramework/Sources/DicomParsing/Internals/DicomImageDecoder.cpp:435
+knownConditionTrueFalse:../../OrthancFramework/Sources/DicomParsing/Internals/DicomImageDecoder.cpp:440
 knownConditionTrueFalse:../../OrthancFramework/Sources/Images/PamReader.cpp:204
 knownConditionTrueFalse:../../OrthancFramework/Sources/Images/PamReader.cpp:207
 knownConditionTrueFalse:../../OrthancFramework/Sources/JobsEngine/Operations/SequenceOfOperationsJob.cpp:345
@@ -45,11 +45,11 @@
 syntaxError:../../OrthancFramework/UnitTestsSources/DicomMapTests.cpp:74
 syntaxError:../../OrthancFramework/UnitTestsSources/ZipTests.cpp:133
 syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:325
-useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:92
+useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:97
 useInitializationList:../../OrthancFramework/Sources/Images/PngWriter.cpp:99
-useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:275
+useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:280
 variableScope:../../OrthancServer/Sources/OrthancRestApi/OrthancRestApi.cpp:230
-variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:94
+variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:97
 EOF
 
 CPPCHECK_BUILD_DIR=/tmp/cppcheck-build-dir-2.17.1/
--- a/OrthancServer/Resources/RunCppCheck-2.20.0.sh	Thu May 07 16:52:02 2026 +0200
+++ b/OrthancServer/Resources/RunCppCheck-2.20.0.sh	Thu May 07 18:17:29 2026 +0200
@@ -24,11 +24,11 @@
 syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h
 syntaxError:../../OrthancFramework/UnitTestsSources/DicomMapTests.cpp:74
 syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:325
-useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:92
+useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:97
 useInitializationList:../../OrthancFramework/Sources/Images/PngWriter.cpp:99
-useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:275
+useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:280
 variableScope:../../OrthancServer/Sources/OrthancRestApi/OrthancRestApi.cpp:230
-variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:94
+variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:97
 EOF
 
 CPPCHECK_BUILD_DIR=/tmp/cppcheck-build-dir-2.20.0/