changeset 6948:676f4cab82de streaming

mutable should be avoided
author Sebastien Jodogne <s.jodogne@gmail.com>
date Sat, 13 Jun 2026 20:09:19 +0200
parents 1026c249158f
children 82cba5fc24a3
files OrthancFramework/Sources/MultiThreading/IExecutorService.h OrthancFramework/Sources/MultiThreading/ThreadPool.cpp OrthancFramework/Sources/MultiThreading/ThreadPool.h
diffstat 3 files changed, 4 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/MultiThreading/IExecutorService.h	Sat Jun 13 19:54:11 2026 +0200
+++ b/OrthancFramework/Sources/MultiThreading/IExecutorService.h	Sat Jun 13 20:09:19 2026 +0200
@@ -44,6 +44,6 @@
 
     virtual void Stop() = 0;
 
-    virtual unsigned int GetCountThreads() const = 0;
+    virtual unsigned int GetCountThreads() = 0;
   };
 }
--- a/OrthancFramework/Sources/MultiThreading/ThreadPool.cpp	Sat Jun 13 19:54:11 2026 +0200
+++ b/OrthancFramework/Sources/MultiThreading/ThreadPool.cpp	Sat Jun 13 20:09:19 2026 +0200
@@ -339,7 +339,7 @@
   }
 
 
-  unsigned int ThreadPool::GetCountThreads() const
+  unsigned int ThreadPool::GetCountThreads()
   {
     boost::mutex::scoped_lock lock(mutex_);
     return countThreads_;
--- a/OrthancFramework/Sources/MultiThreading/ThreadPool.h	Sat Jun 13 19:54:11 2026 +0200
+++ b/OrthancFramework/Sources/MultiThreading/ThreadPool.h	Sat Jun 13 20:09:19 2026 +0200
@@ -49,7 +49,7 @@
 
     SharedMessageQueue                    queue_;
     std::unique_ptr<boost::thread_group>  workers_;
-    mutable boost::mutex                  mutex_;
+    boost::mutex                          mutex_;
     std::string                           loggingThreadName_;
     unsigned int                          countThreads_;
     State                                 state_;
@@ -70,7 +70,7 @@
 
     void SetCountThreads(unsigned int count);
 
-    virtual unsigned int GetCountThreads() const ORTHANC_OVERRIDE;
+    virtual unsigned int GetCountThreads() ORTHANC_OVERRIDE;
 
     void SetDequeueTimeout(unsigned int milliseconds);