Mercurial > hg > orthanc

changeset 6495:31e793f606bc

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Alain Mazy <am@orthanc.team>
date Tue, 25 Nov 2025 16:07:04 +0100
parents f9fd84b5ffeb
children cde9c325f25e 87138d16a90d
files OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.cpp OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.h OrthancServer/Resources/RunCppCheck-2.17.1.sh
diffstat 3 files changed, 16 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.cpp	Tue Nov 25 15:52:40 2025 +0100
+++ b/OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.cpp	Tue Nov 25 16:07:04 2025 +0100
@@ -55,12 +55,10 @@
 
 
   DicomConnectionInfo::DicomConnectionInfo(const Json::Value& serialized) :
-    manufacturer_(ModalityManufacturer_Generic)
+    remoteIp_(SerializationToolbox::ReadString(serialized, REMOTE_IP)),
+    remoteAet_(SerializationToolbox::ReadString(serialized, REMOTE_AET)),
+    calledAet_(SerializationToolbox::ReadString(serialized, CALLED_AET))
   {
-    calledAet_ = SerializationToolbox::ReadString(serialized, CALLED_AET);
-    remoteAet_ = SerializationToolbox::ReadString(serialized, REMOTE_AET);
-    remoteIp_ = SerializationToolbox::ReadString(serialized, REMOTE_IP);
-
     std::string manufacturer = SerializationToolbox::ReadString(serialized, MANUFACTURER);
     manufacturer_ = StringToModalityManufacturer(manufacturer);
   }
--- a/OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.h	Tue Nov 25 15:52:40 2025 +0100
+++ b/OrthancFramework/Sources/DicomNetworking/DicomConnectionInfo.h	Tue Nov 25 16:07:04 2025 +0100
@@ -63,7 +63,7 @@
     {
     }
 
-    DicomConnectionInfo(const Json::Value& serialized);
+    explicit DicomConnectionInfo(const Json::Value& serialized);
 
     void Serialize(Json::Value& target) const;
 
--- a/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Tue Nov 25 15:52:40 2025 +0100
+++ b/OrthancServer/Resources/RunCppCheck-2.17.1.sh	Tue Nov 25 16:07:04 2025 +0100
@@ -17,7 +17,7 @@
 constParameterCallback:../../OrthancFramework/Sources/DicomNetworking/Internals/StoreScp.cpp:112
 constParameterCallback:../../OrthancFramework/Sources/DicomNetworking/Internals/StoreScp.cpp:113
 constParameterCallback:../../OrthancFramework/Sources/Pkcs11.cpp:125
-constParameterCallback:../../OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp:3493
+constParameterCallback:../../OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp:3500
 constParameterCallback:../../OrthancServer/Sources/OrthancGetRequestHandler.cpp:47
 constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:447
 constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:451
@@ -26,19 +26,19 @@
 cstyleCast:../../OrthancServer/Plugins/Engine/PluginsManager.cpp:124
 cstyleCast:../../OrthancServer/Plugins/Engine/PluginsManager.cpp:140
 cstyleCast:../../OrthancServer/Plugins/Engine/PluginsManager.cpp:85
-knownConditionTrueFalse:../../OrthancFramework/Sources/DicomNetworking/Internals/CommandDispatcher.cpp:114
+knownConditionTrueFalse:../../OrthancFramework/Sources/DicomNetworking/Internals/CommandDispatcher.cpp:115
 knownConditionTrueFalse:../../OrthancFramework/Sources/DicomParsing/Internals/DicomImageDecoder.cpp:425
 knownConditionTrueFalse:../../OrthancFramework/Sources/JobsEngine/Operations/SequenceOfOperationsJob.cpp:345
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2291
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2292
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2293
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2294
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2295
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2296
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2297
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2298
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2299
-knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2300
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2404
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2405
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2406
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2407
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2408
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2409
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2410
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2411
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2412
+knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp:2413
 nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:321
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:166
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:74