changeset 6397:252867eea2db

cppcheck: virtualCallInConstructor
author Alain Mazy <am@orthanc.team>
date Wed, 12 Nov 2025 18:00:57 +0100
parents 5eac63633d1d
children 55db426a8667
files OrthancFramework/Sources/JobsEngine/Operations/SequenceOfOperationsJob.cpp OrthancFramework/UnitTestsSources/RestApiTests.cpp OrthancServer/Sources/OrthancWebDav.h OrthancServer/Sources/ServerJobs/ArchiveJob.cpp
diffstat 4 files changed, 4 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/JobsEngine/Operations/SequenceOfOperationsJob.cpp	Wed Nov 12 17:55:00 2025 +0100
+++ b/OrthancFramework/Sources/JobsEngine/Operations/SequenceOfOperationsJob.cpp	Wed Nov 12 18:00:57 2025 +0100
@@ -460,7 +460,7 @@
     done_(false)
   {
     std::string jobType;
-    GetJobType(jobType);
+    SequenceOfOperationsJob::GetJobType(jobType);
     
     if (SerializationToolbox::ReadString(serialized, TYPE) != jobType ||
         !serialized.isMember(OPERATIONS) ||
--- a/OrthancFramework/UnitTestsSources/RestApiTests.cpp	Wed Nov 12 17:55:00 2025 +0100
+++ b/OrthancFramework/UnitTestsSources/RestApiTests.cpp	Wed Nov 12 18:00:57 2025 +0100
@@ -402,7 +402,7 @@
     void Reset()
     {
       HttpContentNegociation::Dictionary parameters;
-      Handle("nope", "nope", parameters);
+      AcceptHandler::Handle("nope", "nope", parameters);
     }
 
     const std::string& GetType() const
--- a/OrthancServer/Sources/OrthancWebDav.h	Wed Nov 12 17:55:00 2025 +0100
+++ b/OrthancServer/Sources/OrthancWebDav.h	Wed Nov 12 18:00:57 2025 +0100
@@ -101,7 +101,7 @@
 
     virtual ~OrthancWebDav() ORTHANC_OVERRIDE
     {
-      Stop();
+      OrthancWebDav::Stop();
     }
 
     virtual bool IsExistingFolder(const UriComponents& path) ORTHANC_OVERRIDE;
--- a/OrthancServer/Sources/ServerJobs/ArchiveJob.cpp	Wed Nov 12 17:55:00 2025 +0100
+++ b/OrthancServer/Sources/ServerJobs/ArchiveJob.cpp	Wed Nov 12 18:00:57 2025 +0100
@@ -209,7 +209,7 @@
 
     virtual ~ThreadedInstanceLoader() ORTHANC_OVERRIDE
     {
-      Clear();
+      ThreadedInstanceLoader::Clear();
     }
 
     virtual void Clear() ORTHANC_OVERRIDE