Mercurial > hg > orthanc

changeset 5984:23cb99dc8b68

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Tue, 21 Jan 2025 17:13:54 +0100
parents 5a6aa72628cb
children 46851fddced2
files OrthancFramework/Sources/DicomParsing/DcmtkTranscoder.h OrthancFramework/UnitTestsSources/JobsTests.cpp OrthancServer/Plugins/Samples/MultitenantDicom/DicomFilter.cpp OrthancServer/Resources/RunCppCheck.sh OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp OrthancServer/Sources/ServerContext.cpp OrthancServer/Sources/ServerJobs/ArchiveJob.cpp OrthancServer/Sources/SimpleInstanceOrdering.cpp
diffstat 8 files changed, 13 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/DicomParsing/DcmtkTranscoder.h	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancFramework/Sources/DicomParsing/DcmtkTranscoder.h	Tue Jan 21 17:13:54 2025 +0100
@@ -51,7 +51,7 @@
                           bool allowNewSopInstanceUid);
     
   public:
-    DcmtkTranscoder(unsigned int maxConcurrentExecutions);
+    explicit DcmtkTranscoder(unsigned int maxConcurrentExecutions);
 
     void SetLossyQuality(unsigned int quality);
 
--- a/OrthancFramework/UnitTestsSources/JobsTests.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancFramework/UnitTestsSources/JobsTests.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -783,7 +783,7 @@
 
 
 static bool CheckIdempotentSerialization(IJobUnserializer& unserializer,
-                                         IJob& job)
+                                         const IJob& job)
 {
   Json::Value a = 42;
   
@@ -809,7 +809,7 @@
 
 
 static bool CheckIdempotentSetOfInstances(IJobUnserializer& unserializer,
-                                          SetOfInstancesJob& job)
+                                          const SetOfInstancesJob& job)
 {
   Json::Value a = 42;
   
--- a/OrthancServer/Plugins/Samples/MultitenantDicom/DicomFilter.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Plugins/Samples/MultitenantDicom/DicomFilter.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -260,7 +260,6 @@
   {
     sopClasses.insert(*it);
     count++;
-    it++;
+    ++it;
   }
-
-}
\ No newline at end of file
+}
--- a/OrthancServer/Resources/RunCppCheck.sh	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Resources/RunCppCheck.sh	Tue Jan 21 17:13:54 2025 +0100
@@ -13,7 +13,7 @@
 knownArgument:../../OrthancFramework/UnitTestsSources/ImageTests.cpp
 knownConditionTrueFalse:../../OrthancServer/Plugins/Engine/OrthancPlugins.cpp
 nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:321
-stlFindInsert:../../OrthancFramework/Sources/DicomFormat/DicomMap.cpp:1510
+stlFindInsert:../../OrthancFramework/Sources/DicomFormat/DicomMap.cpp:1525
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:166
 stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:74
 stlFindInsert:../../OrthancServer/Sources/Database/MainDicomTagsRegistry.cpp:65
@@ -27,7 +27,7 @@
 syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:322
 uninitMemberVar:../../OrthancServer/Sources/ServerJobs/StorageCommitmentScpJob.cpp:417
 unreadVariable:../../OrthancFramework/Sources/FileStorage/StorageAccessor.cpp
-unreadVariable:../../OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp:1123
+unreadVariable:../../OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp:1173
 unusedFunction
 useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:91
 useInitializationList:../../OrthancFramework/Sources/Images/PngWriter.cpp:99
--- a/OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Sources/OrthancRestApi/OrthancRestModalities.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -1588,7 +1588,7 @@
 
   void ParseMoveGetJob(DicomRetrieveScuBaseJob& job, Json::Value& request, RestApiPostCall& call)
   {
-    ServerContext& context = OrthancRestApi::GetContext(call);
+    const ServerContext& context = OrthancRestApi::GetContext(call);
 
     if (!call.ParseJsonRequest(request) ||
         request.type() != Json::objectValue ||
--- a/OrthancServer/Sources/ServerContext.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Sources/ServerContext.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -2128,7 +2128,7 @@
     {
       sopClasses.insert(*it);
       count++;
-      it++;
+      ++it;
     }
   }
 
--- a/OrthancServer/Sources/ServerJobs/ArchiveJob.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Sources/ServerJobs/ArchiveJob.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -530,7 +530,7 @@
 
       Instance(const std::string& id,
                uint32_t index,
-               FileInfo fileInfo) : 
+               const FileInfo& fileInfo) :
         id_(id),
         index_(index),
         fileInfo_(fileInfo)
--- a/OrthancServer/Sources/SimpleInstanceOrdering.cpp	Tue Jan 21 16:52:35 2025 +0100
+++ b/OrthancServer/Sources/SimpleInstanceOrdering.cpp	Tue Jan 21 17:13:54 2025 +0100
@@ -47,7 +47,9 @@
 
 
   public:
-    Instance(const std::string& instanceId, uint32_t indexInSeries, FileInfo fileInfo) :
+    Instance(const std::string& instanceId,
+             uint32_t indexInSeries,
+             const FileInfo& fileInfo) :
       instanceId_(instanceId),
       indexInSeries_(indexInSeries),
       fileInfo_(fileInfo)