Mercurial > hg > orthanc

changeset 7076:0ffe3053d2f8 streaming

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Wed, 12 Aug 2026 12:52:37 +0200
parents a4a2eaf3401c
children 000558ca57ae
files OrthancFramework/Sources/DataSource/DataSourceReader.h OrthancFramework/Sources/DataSource/StorageAreaDataSource.cpp OrthancServer/Resources/RunCppCheck-2.20.0.sh OrthancServer/Sources/ServerContext.cpp
diffstat 4 files changed, 17 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/DataSource/DataSourceReader.h	Wed Aug 12 12:43:54 2026 +0200
+++ b/OrthancFramework/Sources/DataSource/DataSourceReader.h	Wed Aug 12 12:52:37 2026 +0200
@@ -87,7 +87,6 @@
 
     boost::shared_ptr<IExecutorService>                   executor_;
     std::unique_ptr<IDataSource>                          source_;
-    size_t                                                cacheSize_;
     boost::shared_ptr<SharedObjectCache>                  cache_;
     boost::shared_ptr<Internals::DataSourceMemoryBudget>  budget_;
     MetricsConfiguration                                  metricsConfiguration_;
--- a/OrthancFramework/Sources/DataSource/StorageAreaDataSource.cpp	Wed Aug 12 12:43:54 2026 +0200
+++ b/OrthancFramework/Sources/DataSource/StorageAreaDataSource.cpp	Wed Aug 12 12:52:37 2026 +0200
@@ -44,7 +44,7 @@
 
 namespace Orthanc
 {
-  static std::string ComputeCacheKey(std::string uuid,
+  static std::string ComputeCacheKey(const std::string& uuid,
                                      FileContentType type,
                                      uint64_t start,
                                      uint64_t end)
--- a/OrthancServer/Resources/RunCppCheck-2.20.0.sh	Wed Aug 12 12:43:54 2026 +0200
+++ b/OrthancServer/Resources/RunCppCheck-2.20.0.sh	Wed Aug 12 12:52:37 2026 +0200
@@ -10,32 +10,32 @@
 fi
 
 cat <<EOF > /tmp/cppcheck-suppressions.txt
-assertWithSideEffect:../../OrthancFramework/Sources/DataSource/DataSourceReader.cpp:310
+assertWithSideEffect:../../OrthancFramework/Sources/DataSource/DataSourceReader.cpp:356
 assertWithSideEffect:../../OrthancServer/Sources/Database/Compatibility/DatabaseLookup.cpp:292
 assertWithSideEffect:../../OrthancServer/Sources/Database/Compatibility/DatabaseLookup.cpp:391
-assertWithSideEffect:../../OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp:287
-constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:452
-constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:456
+assertWithSideEffect:../../OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp:293
+constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:450
+constParameterPointer:../../OrthancFramework/Sources/Logging.cpp:454
 constParameterPointer:../../OrthancFramework/Sources/Toolbox.cpp:3467
 missingInclude:../../OrthancServer/Plugins/Engine/OrthancPluginDatabaseV4.cpp:41
 nullPointer:../../OrthancFramework/UnitTestsSources/RestApiTests.cpp:321
-stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:166
-stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:74
-stlFindInsert:../../OrthancServer/Sources/Database/ResourcesContent.h:141
-syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h
-syntaxError:../../OrthancFramework/UnitTestsSources/DicomMapTests.cpp:74
-syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:325
-useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:95
-useInitializationList:../../OrthancFramework/Sources/Images/PngWriter.cpp:99
-useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:277
-variableScope:../../OrthancServer/Sources/OrthancRestApi/OrthancRestApi.cpp:230
-variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:98
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:517
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:518
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:519
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:520
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:521
 sizeofCalculation:../../OrthancFramework/UnitTestsSources/ToolboxTests.cpp:522
+stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:166
+stlFindInsert:../../OrthancFramework/Sources/RestApi/RestApiCallDocumentation.cpp:74
+stlFindInsert:../../OrthancServer/Sources/Database/ResourcesContent.h:141
+syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h
+syntaxError:../../OrthancFramework/UnitTestsSources/DicomMapTests.cpp:74
+syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:345
+useInitializationList:../../OrthancFramework/Sources/Images/PngReader.cpp:95
+useInitializationList:../../OrthancFramework/Sources/Images/PngWriter.cpp:99
+useInitializationList:../../OrthancServer/Sources/ServerJobs/DicomModalityStoreJob.cpp:277
+variableScope:../../OrthancServer/Sources/OrthancRestApi/OrthancRestApi.cpp:230
+variableScope:../../OrthancServer/Sources/ServerJobs/OrthancPeerStoreJob.cpp:98
 EOF
 
 CPPCHECK_BUILD_DIR=/tmp/cppcheck-build-dir-2.20.0/
--- a/OrthancServer/Sources/ServerContext.cpp	Wed Aug 12 12:43:54 2026 +0200
+++ b/OrthancServer/Sources/ServerContext.cpp	Wed Aug 12 12:52:37 2026 +0200
@@ -499,7 +499,7 @@
 
 
   static void GetMemorySizeConfiguration(uint64_t& result,
-                                         OrthancConfiguration::ReaderLock& lock,
+                                         const OrthancConfiguration::ReaderLock& lock,
                                          const char* parameter)
   {
     unsigned int mb;