Mercurial > hg > orthanc
annotate OrthancServer/ServerJobs/Operations/SystemCallOperation.cpp @ 3181:6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
| author | Sebastien Jodogne <s.jodogne@gmail.com> |
|---|---|
| date | Thu, 31 Jan 2019 15:33:27 +0100 |
| parents | beeeb6096f27 |
| children | 94f4a18a79cc |
| rev | line source |
|---|---|
| 2606 | 1 /** |
| 2 * Orthanc - A Lightweight, RESTful DICOM Store | |
| 3 * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics | |
| 4 * Department, University Hospital of Liege, Belgium | |
|
3060
4e43e67f8ecf
preparing for 2019
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2659
diff
changeset
|
5 * Copyright (C) 2017-2019 Osimis S.A., Belgium |
| 2606 | 6 * |
| 7 * This program is free software: you can redistribute it and/or | |
| 8 * modify it under the terms of the GNU General Public License as | |
| 9 * published by the Free Software Foundation, either version 3 of the | |
| 10 * License, or (at your option) any later version. | |
| 11 * | |
| 12 * In addition, as a special exception, the copyright holders of this | |
| 13 * program give permission to link the code of its release with the | |
| 14 * OpenSSL project's "OpenSSL" library (or with modified versions of it | |
| 15 * that use the same license as the "OpenSSL" library), and distribute | |
| 16 * the linked executables. You must obey the GNU General Public License | |
| 17 * in all respects for all of the code used other than "OpenSSL". If you | |
| 18 * modify file(s) with this exception, you may extend this exception to | |
| 19 * your version of the file(s), but you are not obligated to do so. If | |
| 20 * you do not wish to do so, delete this exception statement from your | |
| 21 * version. If you delete this exception statement from all source files | |
| 22 * in the program, then also delete it here. | |
| 23 * | |
| 24 * This program is distributed in the hope that it will be useful, but | |
| 25 * WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 26 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 27 * General Public License for more details. | |
| 28 * | |
| 29 * You should have received a copy of the GNU General Public License | |
| 30 * along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| 31 **/ | |
| 32 | |
| 33 | |
| 2641 | 34 #include "../../PrecompiledHeadersServer.h" |
| 2606 | 35 #include "SystemCallOperation.h" |
| 36 | |
| 37 #include "DicomInstanceOperationValue.h" | |
| 38 | |
| 2641 | 39 #include "../../../Core/JobsEngine/Operations/StringOperationValue.h" |
| 40 #include "../../../Core/Logging.h" | |
| 2659 | 41 #include "../../../Core/OrthancException.h" |
|
2656
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
42 #include "../../../Core/SerializationToolbox.h" |
| 2641 | 43 #include "../../../Core/TemporaryFile.h" |
| 44 #include "../../../Core/Toolbox.h" | |
|
3095
beeeb6096f27
removing dependencies upon ServerContext
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3060
diff
changeset
|
45 #include "../../../Core/SystemToolbox.h" |
|
3181
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
46 #include "../../OrthancConfiguration.h" |
| 2606 | 47 |
| 48 namespace Orthanc | |
| 49 { | |
| 2659 | 50 const std::string& SystemCallOperation::GetPreArgument(size_t i) const |
| 51 { | |
| 52 if (i >= preArguments_.size()) | |
| 53 { | |
| 54 throw OrthancException(ErrorCode_ParameterOutOfRange); | |
| 55 } | |
| 56 else | |
| 57 { | |
| 58 return preArguments_[i]; | |
| 59 } | |
| 60 } | |
| 61 | |
| 62 | |
| 63 const std::string& SystemCallOperation::GetPostArgument(size_t i) const | |
| 64 { | |
| 65 if (i >= postArguments_.size()) | |
| 66 { | |
| 67 throw OrthancException(ErrorCode_ParameterOutOfRange); | |
| 68 } | |
| 69 else | |
| 70 { | |
| 71 return postArguments_[i]; | |
| 72 } | |
| 73 } | |
| 74 | |
| 75 | |
| 2606 | 76 void SystemCallOperation::Apply(JobOperationValues& outputs, |
|
2608
25225f0b4f33
simplification wrt. dicom connection manager
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2607
diff
changeset
|
77 const JobOperationValue& input, |
|
25225f0b4f33
simplification wrt. dicom connection manager
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2607
diff
changeset
|
78 IDicomConnectionManager& connectionManager) |
| 2606 | 79 { |
| 80 std::vector<std::string> arguments = preArguments_; | |
| 81 | |
| 82 arguments.reserve(arguments.size() + postArguments_.size() + 1); | |
| 83 | |
| 84 std::auto_ptr<TemporaryFile> tmp; | |
| 85 | |
| 86 switch (input.GetType()) | |
| 87 { | |
| 88 case JobOperationValue::Type_DicomInstance: | |
| 89 { | |
| 90 const DicomInstanceOperationValue& instance = | |
| 91 dynamic_cast<const DicomInstanceOperationValue&>(input); | |
| 92 | |
| 93 std::string dicom; | |
|
2651
1da5a052c777
testing value serialization
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2641
diff
changeset
|
94 instance.ReadDicom(dicom); |
| 2606 | 95 |
|
3181
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
96 { |
|
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
97 OrthancConfiguration::ReaderLock lock; |
|
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
98 tmp.reset(lock.GetConfiguration().CreateTemporaryFile()); |
|
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
99 } |
|
6fd38327e777
Fix issue #130 (Orthanc failed to start when /tmp partition was full)
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3095
diff
changeset
|
100 |
| 2606 | 101 tmp->Write(dicom); |
| 102 | |
| 103 arguments.push_back(tmp->GetPath()); | |
| 104 break; | |
| 105 } | |
| 106 | |
| 107 case JobOperationValue::Type_String: | |
| 108 { | |
| 109 const StringOperationValue& value = | |
| 110 dynamic_cast<const StringOperationValue&>(input); | |
| 111 | |
| 112 arguments.push_back(value.GetContent()); | |
| 113 break; | |
| 114 } | |
| 115 | |
| 116 case JobOperationValue::Type_Null: | |
| 117 break; | |
| 118 | |
| 119 default: | |
| 120 throw OrthancException(ErrorCode_BadParameterType); | |
| 121 } | |
| 122 | |
| 123 for (size_t i = 0; i < postArguments_.size(); i++) | |
| 124 { | |
| 125 arguments.push_back(postArguments_[i]); | |
| 126 } | |
| 127 | |
| 128 std::string info = command_; | |
| 129 for (size_t i = 0; i < arguments.size(); i++) | |
| 130 { | |
| 131 info += " " + arguments[i]; | |
| 132 } | |
| 133 | |
|
2607
44e268605478
ModifyInstanceOperation
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2606
diff
changeset
|
134 LOG(INFO) << "Lua: System call: \"" << info << "\""; |
| 2606 | 135 |
| 136 try | |
| 137 { | |
| 138 SystemToolbox::ExecuteSystemCommand(command_, arguments); | |
| 139 | |
| 140 // Only chain with other commands if this operation succeeds | |
| 141 outputs.Append(input.Clone()); | |
| 142 } | |
| 143 catch (OrthancException& e) | |
| 144 { | |
|
2607
44e268605478
ModifyInstanceOperation
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2606
diff
changeset
|
145 LOG(ERROR) << "Lua: Failed system call - \"" << info << "\": " << e.What(); |
| 2606 | 146 } |
| 147 } | |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
148 |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
149 |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
150 void SystemCallOperation::Serialize(Json::Value& result) const |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
151 { |
| 2654 | 152 result = Json::objectValue; |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
153 result["Type"] = "SystemCall"; |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
154 result["Command"] = command_; |
|
2656
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
155 SerializationToolbox::WriteArrayOfStrings(result, preArguments_, "PreArguments"); |
|
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
156 SerializationToolbox::WriteArrayOfStrings(result, postArguments_, "PostArguments"); |
| 2655 | 157 } |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
158 |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
159 |
| 2655 | 160 SystemCallOperation::SystemCallOperation(const Json::Value& serialized) |
| 161 { | |
|
2656
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
162 if (SerializationToolbox::ReadString(serialized, "Type") != "SystemCall") |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
163 { |
| 2655 | 164 throw OrthancException(ErrorCode_BadFileFormat); |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
165 } |
|
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
166 |
|
2656
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
167 command_ = SerializationToolbox::ReadString(serialized, "Command"); |
|
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
168 SerializationToolbox::ReadArrayOfStrings(preArguments_, serialized, "PreArguments"); |
|
a6d3e45eeff5
SerializationToolbox
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2655
diff
changeset
|
169 SerializationToolbox::ReadArrayOfStrings(postArguments_, serialized, "PostArguments"); |
|
2616
2f3007bf0708
event queues in Lua, serialization of sequence of operations
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
2608
diff
changeset
|
170 } |
| 2606 | 171 } |