Mercurial > hg > orthanc-stone

changeset 2176:c5f94c10cd61

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Tue, 22 Oct 2024 21:59:25 +0200
parents 43ef60388fa2
children 4d21befb1501
files Applications/Resources/RunCppCheck.sh OrthancStone/Sources/Toolbox/OrthancDatasets/DicomWebDataset.h OrthancStone/Sources/Toolbox/OrthancDatasets/OrthancNativeDataset.h
diffstat 3 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/Applications/Resources/RunCppCheck.sh	Tue Oct 22 21:54:39 2024 +0200
+++ b/Applications/Resources/RunCppCheck.sh	Tue Oct 22 21:59:25 2024 +0200
@@ -33,8 +33,8 @@
 assertWithSideEffect:../../OrthancStone/Sources/Loaders/OrthancMultiframeVolumeLoader.cpp:342
 constParameter:../../RenderingPlugin/Sources/Plugin.cpp:778
 stlFindInsert:../../Applications/Samples/WebAssembly/SingleFrameViewer/SingleFrameViewerApplication.h
-stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:1245
-stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:601
+stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:1389
+stlFindInsert:../../Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp:672
 unpreciseMathCall:../../OrthancStone/Sources/Scene2D/Internals/CairoFloatTextureRenderer.cpp
 unpreciseMathCall:../../OrthancStone/Sources/Scene2D/LookupTableTextureSceneLayer.cpp
 unreadVariable:../../OrthancStone/Sources/Platforms/Sdl/SdlViewport.cpp:159
--- a/OrthancStone/Sources/Toolbox/OrthancDatasets/DicomWebDataset.h	Tue Oct 22 21:54:39 2024 +0200
+++ b/OrthancStone/Sources/Toolbox/OrthancDatasets/DicomWebDataset.h	Tue Oct 22 21:59:25 2024 +0200
@@ -39,7 +39,7 @@
                                    const Orthanc::DicomPath& path) const;
 
   public:
-    DicomWebDataset(const Json::Value& dicomweb);
+    explicit DicomWebDataset(const Json::Value& dicomweb);
 
     virtual bool GetStringValue(std::string& result,
                                 const Orthanc::DicomPath& path) const ORTHANC_OVERRIDE;
--- a/OrthancStone/Sources/Toolbox/OrthancDatasets/OrthancNativeDataset.h	Tue Oct 22 21:54:39 2024 +0200
+++ b/OrthancStone/Sources/Toolbox/OrthancDatasets/OrthancNativeDataset.h	Tue Oct 22 21:59:25 2024 +0200
@@ -39,12 +39,12 @@
                                    const Orthanc::DicomPath& path) const;
 
   public:
-    OrthancNativeDataset(const Orthanc::DicomMap& dicom) :
+    explicit OrthancNativeDataset(const Orthanc::DicomMap& dicom) :
       dicom_(dicom.Clone())
     {
     }
 
-    OrthancNativeDataset(const Json::Value& dicom);
+    explicit OrthancNativeDataset(const Json::Value& dicom);
 
     virtual bool GetStringValue(std::string& result,
                                 const Orthanc::DicomPath& path) const ORTHANC_OVERRIDE;