diff Framework/OpenGL/OpenGLIncludes.h @ 961:92e32e263ae9 toa2019082601

Removed log in IsContextLost (too many calls) + removed glGetError guards on calls (expensive) + added shared_ptr ref count dump in LoaderCache (still needs to figure that one out)
author Benjamin Golinvaux <bgo@osimis.io>
date Mon, 26 Aug 2019 11:01:53 +0200
parents 1091b2adeb5a
children 3ea70a62ca00
line wrap: on
line diff
--- a/Framework/OpenGL/OpenGLIncludes.h	Fri Aug 23 15:02:42 2019 +0200
+++ b/Framework/OpenGL/OpenGLIncludes.h	Mon Aug 26 11:01:53 2019 +0200
@@ -41,9 +41,19 @@
 #endif
 
 #if ORTHANC_ENABLE_SDL == 1
-#include <SDL_video.h>
+# include <SDL_video.h>
+
+# ifdef NDEBUG
+
+// glGetError is very expensive!
 
-#define ORTHANC_OPENGL_CHECK(name) \
+#   define ORTHANC_OPENGL_CHECK(name)
+#   define ORTHANC_OPENGL_TRACE_CURRENT_CONTEXT(msg)
+#   define ORTHANC_CHECK_CURRENT_CONTEXT(context)
+
+# else 
+
+#   define ORTHANC_OPENGL_CHECK(name) \
 if(true)                                                                                                                                \
 {                                                                                                                                       \
   GLenum error = glGetError();                                                                                                          \
@@ -54,14 +64,14 @@
   }                                                                                                                                     \
 } else (void)0
 
-#define ORTHANC_OPENGL_TRACE_CURRENT_CONTEXT(msg)                          \
+#   define ORTHANC_OPENGL_TRACE_CURRENT_CONTEXT(msg)                          \
 if(true)                                                                   \
 {                                                                          \
   SDL_GLContext ctx = SDL_GL_GetCurrentContext();                          \
   LOG(TRACE) << msg << " | Current OpenGL context is " << std::hex << ctx; \
 } else (void)0
 
-#define ORTHANC_CHECK_CURRENT_CONTEXT(context)                                                                                                         \
+#   define ORTHANC_CHECK_CURRENT_CONTEXT(context)                                                                                                         \
 if(true)                                                                                                                                               \
 {                                                                                                                                                      \
   SDL_GLContext actualCtx = SDL_GL_GetCurrentContext();                                                                                                \
@@ -72,6 +82,8 @@
   }                                                                                                                                                    \
 } else (void)0
 
+# endif
+
 #endif
 
 #if ORTHANC_ENABLE_WASM == 1