annotate TODO @ 1940:69589c7fe58d

todo: auth headers
author Alain Mazy <am@osimis.io>
date Tue, 10 May 2022 16:49:00 +0200
parents efed41b76dc7
children 4ad58ca3909c
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
1
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
2 ======================
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
3 == Stone Web viewer ==
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
4 ======================
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
5
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
6 ------------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
7 Improvements
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
8 ------------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
9
1830
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
10 * Save/load annotations as attachments of their parent series
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
11 (including detection of collisions thanks to revisions).
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
12 https://book.orthanc-server.com/faq/features.html#metadata-attachments
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
13
1847
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1834
diff changeset
14 * Internationalization and translations (i18n). Some possible libraries:
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
15 https://phrase.com/blog/posts/the-best-javascript-i18n-libraries/
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
16
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
17 * Configurable keyboard shortcuts. See Osimis Web viewer:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
18 https://bitbucket.org/osimis/osimis-webviewer-plugin/src/master/doc/default-configuration.json
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
19
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
20 * Flip X/Y : Should change the affine transformation of the 2D scene,
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
21 not the texture. Flipping the texture makes the reference lines and
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
22 crosshair invalid.
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
23
1730
af4a2d08549c preparing for release
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1726
diff changeset
24 * Handle mobile gestures.
af4a2d08549c preparing for release
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1726
diff changeset
25
1847
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1834
diff changeset
26 * Display GSPS layers (Grayscale Softcopy Presentation State).
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1834
diff changeset
27
1930
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
28 * Use "ImagerPixelSpacing" (0018,1164) tag if "PixelSpacing" is missing
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
29
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
30 * Override which tags are displayed in the image information in the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
31 top-left, top-right and bottom-right pannels.
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
32
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
33 For reference, in the case of MRI, "Echo Time" (0018,0081),
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
34 "Repetition Time" (0018,0080), "Magnetic Field Strength (0018,0087)
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
35 and "Slice Thickness" (0018,0050) would be useful to have.
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
36
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
37 https://groups.google.com/g/orthanc-users/c/_kDp_ieYTgI/m/KHBxpSSOCQAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
38
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
39
1867
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
40 ------------
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
41 Known issues
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
42 ------------
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
43
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
44 * When opening a CT with 700 slices, if you drop the thumbnail in the viewport
1939
Alain Mazy <am@osimis.io>
parents: 1938
diff changeset
45 before the studies/../metadata have been loaded, the series will never be displayed.
Alain Mazy <am@osimis.io>
parents: 1938
diff changeset
46 https://groups.google.com/g/orthanc-users/c/04D4exKMVSA
1867
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
47
1925
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1922
diff changeset
48 * Compatibility with Google Chrome browser on iPad Air 4:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1922
diff changeset
49 https://groups.google.com/g/orthanc-users/c/7SgedbIiA2k/
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1922
diff changeset
50 https://groups.google.com/g/orthanc-users/c/RfQJFgkOUYY/m/za7rkcLNBQAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1922
diff changeset
51
1940
69589c7fe58d todo: auth headers
Alain Mazy <am@osimis.io>
parents: 1939
diff changeset
52 * the authorization header ('token' query arg) is not included in the HTTP headers.
69589c7fe58d todo: auth headers
Alain Mazy <am@osimis.io>
parents: 1939
diff changeset
53 Tested with https://bitbucket.org/osimis/orthanc-setup-samples/src/master/docker/authorization-plugin-viewer-query-args/.
69589c7fe58d todo: auth headers
Alain Mazy <am@osimis.io>
parents: 1939
diff changeset
54
1925
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1922
diff changeset
55
1830
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
56 -----------------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
57 Code refactorings
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
58 -----------------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
59
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
60 * Replace "ParsedDicomCache" by "Orthanc::ParsedDicomCache" (new in
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
61 Orthanc framework 1.9.0)
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
62
1938
Alain Mazy <am@osimis.io>
parents: 1935
diff changeset
63 * Replace calls to /studies/.../series/.../metadata by calls to
Alain Mazy <am@osimis.io>
parents: 1935
diff changeset
64 /instances?StudyInstanceUID=...&SeriesInstanceUID=...&includefield=...&includefield=...
Alain Mazy <am@osimis.io>
parents: 1935
diff changeset
65 to benefit from ExtraMainDicomTags stored in DB and avoid reading from disk
1830
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1829
diff changeset
66
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
67 --------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
68 Wishlist
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
69 --------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
70
1719
9a1f79d21a3f added buttons to go to the first and last frames
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1717
diff changeset
71 * Vertical "timeline" to see the position of the current frame in the
9a1f79d21a3f added buttons to go to the first and last frames
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1717
diff changeset
72 series, and to change the current frame by clicking on the timeline.
9a1f79d21a3f added buttons to go to the first and last frames
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1717
diff changeset
73
1863
Alain Mazy <am@osimis.io>
parents: 1848
diff changeset
74 * Display a pixel probe with the Hounsfield Unit.
Alain Mazy <am@osimis.io>
parents: 1848
diff changeset
75 https://groups.google.com/g/orthanc-users/c/m7S0wbYYW5s/m/MBaxIQ_IAAAJ
Alain Mazy <am@osimis.io>
parents: 1848
diff changeset
76
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
77 * Display video files even if the Orthanc REST API is not available
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
78 (using pure DICOMweb). This could possible be done using the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
79 DICOMweb Bulk Data URI, and/or a dedicated JavaScript video player.
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
80
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
81 * "Start the Viewer with a specific Dicom file and display the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
82 specific images. For example I start the Viewer with dicomFile and
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
83 open slide1, slide4, slide8, slide12 ?"
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
84 https://groups.google.com/g/orthanc-users/c/6KSe0WEEfco/m/nOIl57EzAAAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
85
1717
391c798e4dae fix for KNIX sample dataset
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1716
diff changeset
86 * Configuration option related to the "DicomSource" class in order to
391c798e4dae fix for KNIX sample dataset
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1716
diff changeset
87 systematically request server-side transcoding.
391c798e4dae fix for KNIX sample dataset
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1716
diff changeset
88
1753
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1741
diff changeset
89 * Fully implement "Basic Image Review" profile from IHE:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1741
diff changeset
90 https://wiki.ihe.net/index.php/Basic_Image_Review
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1741
diff changeset
91
1848
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1847
diff changeset
92 * Support hanging protocols (automatically adapt the layout given the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1847
diff changeset
93 type of modality to be displayed):
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1847
diff changeset
94 https://groups.google.com/g/orthanc-users/c/bGtK3q9ZUmg/m/gr8kCcVWCAAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1847
diff changeset
95
1867
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
96 * When opening the viewer, directly load the first series in the viewport
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
97 (like the OsimisViewer). Whatchout the known issues wrt dropping a series
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
98 before the studies/../metadata have been loaded.
Alain Mazy <am@osimis.io>
parents: 1865
diff changeset
99
1932
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1930
diff changeset
100 * Create secondary capture DICOM images with the annotations burned in:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1930
diff changeset
101 https://groups.google.com/g/orthanc-users/c/T3h-6dIjvww/m/sVtHxwT_AQAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1930
diff changeset
102
1933
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1932
diff changeset
103 * Configure the default layout (e.g. 1x2 instead of 1x1) and the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1932
diff changeset
104 default view of the left toolbox:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1932
diff changeset
105 https://groups.google.com/g/orthanc-users/c/y2B_RIzegNc/m/H9MhY9y2AgAJ
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1932
diff changeset
106
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1932
diff changeset
107
1935
49c615745708 fix typo
Alain Mazy <am@osimis.io>
parents: 1934
diff changeset
108 * Display the PatientName & ID in the page title such that it appears
1934
Alain Mazy <am@osimis.io>
parents: 1933
diff changeset
109 in the browser tab name
Alain Mazy <am@osimis.io>
parents: 1933
diff changeset
110 https://groups.google.com/g/orthanc-users/c/F7cK8axehfA/m/ku-CPsvbAQAJ
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
111
1930
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
112 --------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
113 Won't do
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
114 --------
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
115
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
116 * Debian packaging, which requires source-level build dependencies:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
117 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975069#22
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
118
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
119 => A solution for AMD64 architectures is to use the standalone
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
120 Debian repository that is provided by Sebastien Jodogne:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
121 https://book.orthanc-server.com/users/cookbook.html#obtaining-binaries
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
122
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
123
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1925
diff changeset
124
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
125 ==================================
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
126 == Stone of Orthanc C++ library ==
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
127 ==================================
0
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
128
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
129
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
130 -------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
131 General
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
132 -------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
133
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
134 * Documentation
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
135
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
136
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
137 -------------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
138 Optimizations
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
139 -------------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
140
1590
7b963bccafef updated README
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 406
diff changeset
141 * Speedup RT-STRUCT projection in sagittal + coronal views
7b963bccafef updated README
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 406
diff changeset
142 * Speedup RT-STRUCT loading
1726
0257339b0884 new method ParseDicomFromWadoCommand::IsSameCommand()
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1719
diff changeset
143 * "ParseDicomFromOrthanc": new command
0
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
144
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
145
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
146 -----------------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
147 Platform-specific
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
148 -----------------
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
149
1716
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
150 * WebAssembly: Possible issue in "emscripten_set_timeout()" if the
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
151 Oracle is destroyed while a sleep event is still being processed
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
152 (the callback payload would be invalid). This is not a problem as
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
153 long as the Oracle singleton is never destroyed. A cleaner solution
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
154 would be similar to "WebAssemblyViewport::CreateObjectCookie()".
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1590
diff changeset
155
0
351ab0da0150 initial commit
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
156 * Add precompiled headers for Microsoft Visual Studio