Bug 98 - DCMTK configuration fails with GCC 6.4.0
Summary: DCMTK configuration fails with GCC 6.4.0
Status: RESOLVED FIXED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Core (show other bugs)
Version: unspecified
Hardware: All All
: --- normal
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2020-06-29 15:14 CEST by Sébastien Jodogne
Modified: 2020-06-29 15:22 CEST (History)
0 users

See Also:

Attachments
orthanc-1.4.1-dcmtk-cmath.patch (2.53 KB, text/x-diff)
2020-06-29 15:18 CEST, Sébastien Jodogne 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Jodogne 2020-06-29 15:14:03 CEST 
[BitBucket user: Miklós Espák]
[BitBucket date: 2018-08-08.15:04:39]

Orthanc already uses a patch to correct how DCMTK detects which functions are available with the given compiler. However, this patch is a bit outdated and it fails with some compilers, specifically with GCC 6.4.0.

Gcc 6.4 is used in alpine linux (3.7 and 3.8) that is popular for making Docker images.

I attached a patch that fixes the problem. It's a patch of the current patch for DCMTK 3.6.2.

The fix is taken from the DCMTK master. Note that DCMTK 3.6.3 still does not have the right fix.
Comment 1 Sébastien Jodogne 2020-06-29 15:18:06 CEST 
Created attachment 70 [details]
orthanc-1.4.1-dcmtk-cmath.patch
Comment 2 Sébastien Jodogne 2020-06-29 15:22:12 CEST 
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2018-09-04.13:07:48]

Fix issue #98 (DCMTK configuration fails with GCC 6.4.0 on Alpine)

→ https://hg.orthanc-server.com/orthanc/changeset/4fdb25c5df9c