Bug 201 - The "Upload" button might report success in the case of a network disconnection
Summary: The "Upload" button might report success in the case of a network disconnection
Status: UNCONFIRMED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Explorer (show other bugs)
Version: unspecified
Hardware: PC All
: --- minor
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2021-08-27 09:22 CEST by Sébastien Jodogne
Modified: 2024-05-19 16:07 CEST (History)
1 user (show)

See Also:


Attachments
Screenshot (230.13 KB, image/jpeg)
2021-08-27 09:22 CEST, Sébastien Jodogne
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Jodogne 2021-08-27 09:22:12 CEST
Created attachment 118 [details]
Screenshot

Message from François Marot on 2021-08-25:
https://groups.google.com/g/orthanc-users/c/B8-7PUTcmDM/m/vQMbN09MAAAJ

"I dig a bit more and found that:
* when uploading a single file with problem (non dicom or corrupted or corrupted zip): we correctly see a red FAILURE
* when uploading multiple files including one with problems (non dicom or corrupted or corrupted zip): we correctly see a red FAILURE
* when uploading a correct zip including some non-dicom or corrupted files: we receive a green DONE (which is a bit misleading but understandable, I do not see a better way as zip files often contain additional garbage, displaying FAILURE would bother users)

But there seems to be a problem when uploading multiple correct ZIP files if a network problem happens. For example, while uploading many files ZIP, if I disconnect from my VPN and then reconnect after a few seconds, some DICOM files are not sent but the green DONE is displayed. See my capture attached. I think this is a wrong behavior. The same test with raw dicom files is correct: a red FAILURE is displayed.
I suppose the handling of zip files is also specific on the client side leading to this problem.

This is not a huge problem and I think when you have many upload to do you should use the API with a script instead of manually using the browser, but I find it interesting to report."
Comment 1 Sébastien Jodogne 2021-08-27 09:29:41 CEST
Answer from SJO on 2021-08-27:
https://groups.google.com/g/orthanc-users/c/B8-7PUTcmDM/m/K7dG3M_BAAAJ

"From what I understand, the issue is not a problem within the Orthanc core, but an issue with the JavaScript library that is used to upload files from Orthanc Explorer to Orthanc, namely "jQuery File Upload Plugin 5.12":
https://github.com/blueimp/jQuery-File-Upload

This version of the library is very outdated (it is now at version 10.31.0), but upgrading it might raise compatibility issues with the other JavaScript libraries used in Orthanc Explorer.

We are really in the field of this FAQ entry:
https://book.orthanc-server.com/faq/improving-interface.html

I am unsure whether this issue will get fixed before creating a brand new "Orthanc Explorer 2", as the REST API is not affected by this issue and should be preferred in clinical deployments."
Comment 2 Robert Junior 2024-05-19 16:07:49 CEST
Answer from SJO on 2021-08-27:
https://groups.google.com/g/orthanc-users/c/B8-7PUTcmDM/m/K7dG3M_BAAAJ https://tubidy.diy/

"From what I understand, the issue is not a problem within the Orthanc core, but an issue with the JavaScript library that is used to upload files from Orthanc Explorer to Orthanc, namely "jQuery File Upload Plugin 5.12":(https://y2mate.diy/)
https://github.com/blueimp/jQuery-File-Upload

This version of the library is very outdated (it is now at version 10.31.0), but upgrading it might raise compatibility issues with the other JavaScript libraries used in Orthanc Explorer.(https://emp3juice.blog/)

We are really in the field of this FAQ entry:
https://book.orthanc-server.com/faq/improving-interface.html

I am unsure whether this issue will get fixed before creating a brand new "Orthanc Explorer 2", as the REST API is not affected by this issue and should be preferred in clinical deployments."