Bug 194 - DICOM 2018 Upgrade
Summary: DICOM 2018 Upgrade
Status: RESOLVED FIXED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Plugin - DICOMweb (show other bugs)
Version: unspecified
Hardware: PC Linux
: --- enhancement
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2021-02-24 14:33 CET by Mathieu Malaterre
Modified: 2021-05-06 14:40 CEST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Malaterre 2021-02-24 14:33:21 CET
DICOM 2018 rework pretty much all of part18.

Please incorporate diff from:

http://dicom.nema.org/medical/dicom/2017c/output/chtml/part18/chapter_6.html#table_6.1.1.8-3b

to:

http://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_8.7.3.3.2.html#table_8.7.3-5


For instance, media type changed from 'image/x-jls' into 'image/jls'

See:

% hg grep jls
Plugin/WadoRsRetrieveFrames.cpp:487:        else if (type == "image/x-jls" && (transferSyntax.empty() ||  // Default
Plugin/WadoRsRetrieveFrames.cpp:487:        else if (type == "image/x-jls" && transferSyntax == "1.2.840.10008.1.2.4.81")
Plugin/WadoRsRetrieveFrames.cpp:487:      return "image/x-jls; transfer-syntax=1.2.840.10008.1.2.4.80";
Plugin/WadoRsRetrieveFrames.cpp:487:      return "image/x-jls; transfer-syntax=1.2.840.10008.1.2.4.81";
Comment 1 Mathieu Malaterre 2021-02-24 17:33:23 CET
Apparently something is still going to be changed:

* https://groups.google.com/g/comp.protocols.dicom/c/3Xa4Z0ykS8g/m/SigNpXhdAgAJ

I guess the WADO-RS standard is pretty confusing :(
Comment 2 Sébastien Jodogne 2021-05-06 14:40:30 CEST
This is fixed by the following changeset, that will be part of DICOMweb 1.6:
https://hg.orthanc-server.com/orthanc-dicomweb/rev/e31fdf2eefe3