Bug 138 - POST to modalities/NAME accepts invalid characters
Summary: POST to modalities/NAME accepts invalid characters
Status: RESOLVED FIXED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Core (show other bugs)
Version: unspecified
Hardware: All All
: --- minor
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2020-06-29 15:15 CEST by Sébastien Jodogne
Modified: 2020-06-29 15:25 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Jodogne 2020-06-29 15:15:28 CEST 
[BitBucket user: Francisco Venancio]
[BitBucket date: 2019-03-29.19:40:12]

So, I just managed to crash our Orthanc instance by sending post requests with several new modalities that contained a underscore in the name. Orthanc accepted this and add the modalities to the database but when it was restart if failed to restart with 

"E0329 16:31:09.897807 OrthancException.h:85] Bad file format: Only alphanumeric and dash characters are allowed in the names of modalities/peers, but found: 4_ANDAR_1" .

As always, I take this opportunity to congratulate Sébastien and the team on an amazing piece of software.
Comment 1 Sébastien Jodogne 2020-06-29 15:25:17 CEST 
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2019-04-05.11:03:06]

Fix issue #138 (POST to modalities/{name} accepts invalid characters)

→ https://hg.orthanc-server.com/orthanc/changeset/8f44dadcdbc1