Bug 118 - Wording in Configuration.json regarding SynchronousCMove
Summary: Wording in Configuration.json regarding SynchronousCMove
Status: RESOLVED FIXED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Core (show other bugs)
Version: unspecified
Hardware: All All
: --- enhancement
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2020-06-29 15:14 CEST by Sébastien Jodogne
Modified: 2020-06-29 15:23 CEST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Jodogne 2020-06-29 15:14:50 CEST
[BitBucket user: Georg Grab]
[BitBucket date: 2018-12-20.13:56:46]

I think the wording in the Configuration has become a bit off regarding SynchronousCMove, as it is not the default behavior anymore. Here is a patch describing what I mean:


```
#!diff

diff -r 1000178f94e4 Resources/Configuration.json
--- a/Resources/Configuration.json      Thu Dec 20 12:22:49 2018 +0100
+++ b/Resources/Configuration.json      Thu Dec 20 13:55:29 2018 +0000
@@ -412,8 +412,8 @@
   },

   // Whether to run DICOM C-Move operations synchronously. If set to
-  // "false" (the default), each incoming C-Move request results in
-  // creating a new background job. Up to Orthanc 1.3.2, the implicit
+  // "false", each incoming C-Move request results in the
+  // creation of a new background job. Up to Orthanc 1.3.2, the implicit
   // behavior was to use synchronous C-Move. Between Orthanc 1.4.0 and
   // 1.4.2, the default behavior was set to asynchronous C-Move. Since
   // Orthanc 1.5.0, the default behavior is synchronous C-Move
```
Comment 1 Sébastien Jodogne 2020-06-29 15:23:02 CEST
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2018-12-20.14:27:08]

Thanks for the heads up! This is fixed by the following changeset: https://hg.orthanc-server.com/orthanc/changeset/095193bbd7b9ff6df6fcd463f6f5fc2af4fb87ab