Bug 1 - Drag and drop file upload has two minor issues
Summary: Drag and drop file upload has two minor issues
Status: CONFIRMED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Explorer (show other bugs)
Version: unspecified
Hardware: All All
: --- minor
Assignee: Sébastien Jodogne
URL:
Depends on:
Blocks:
 
Reported: 2020-06-29 15:11 CEST by Sébastien Jodogne
Modified: 2020-06-29 15:24 CEST (History)
0 users

See Also:

Attachments
1918679651-Capture.PNG (48.87 KB, image/png)
2020-06-29 15:24 CEST, Sébastien Jodogne 		Details
2741110632-Capture.PNG (59.43 KB, image/png)
2020-06-29 15:24 CEST, Sébastien Jodogne 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Jodogne 2020-06-29 15:11:02 CEST 
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2015-09-08.12:55:33]

Reported by andycrabb, Feb 28, 2015 as issue 28 on Google Code

**What steps will reproduce the problem?**

1. Drag and drop files onto 'Upload DICOM files' screen
2. Cancel out of login dialog

**What is the expected output? What do you see instead?**

All files to be uploaded are listed twice.  And you have to cancel out of the 'Authentication Required'  dialog box for each file, if you don't successfully log in.

**What version of the product are you using? On what operating system?**

Orthanc 0.8.6 on Linux (Amazon AMI)
Comment 1 Sébastien Jodogne 2020-06-29 15:18:34 CEST 
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2015-09-08.12:56:45]

*Comment by mp.zwiers on Apr 27, 2015*

I've also seen this duplicative list behaviour. Reloading (refreshing) the page (sometimes twice) can make the problem go away
Comment 2 Sébastien Jodogne 2020-06-29 15:23:30 CEST 
[BitBucket user: Alain Mazy]
[BitBucket date: 2019-01-10.10:20:57]

Just added a log to try to debug the "twice listed" issue and I've not been able to reproduce it afterwards.  So let's keep the log... https://hg.orthanc-server.com/orthanc/changeset/b311cff247cab5a370fd1f88150fec1ec56469d9
Comment 3 Sébastien Jodogne 2020-06-29 15:24:09 CEST 
[BitBucket user: Alain Mazy]
[BitBucket date: 2019-01-24.09:23:48]

I've captured the bug while doing something else (will look later):
![Capture.PNG](1918679651-Capture.PNG)

So, this means that the `fileuploaddrop` event is fired twice with the same content (1 file in this case)

And it seems that the event is triggered twice at very high level (from jquery) because I passed 2 times in this code:
![Capture.PNG](2741110632-Capture.PNG)

So I've added a log to detect if the event is being registered twice: https://hg.orthanc-server.com/orthanc/changeset/4cfed5c2eacd850db5654f46dbb0f8192d07c781
Comment 4 Sébastien Jodogne 2020-06-29 15:24:11 CEST 
Created attachment 102 [details]
1918679651-Capture.PNG
Comment 5 Sébastien Jodogne 2020-06-29 15:24:13 CEST 
Created attachment 103 [details]
2741110632-Capture.PNG