Mercurial > hg > orthanc

changeset 4177:f0d81320f17f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
removed references to unused Manufacturer_StoreScp
author Alain Mazy <alain@mazy.be>
date Thu, 03 Sep 2020 18:43:18 +0200
parents 0a954155aea5
children 3576616904d3
files OrthancFramework/Sources/Enumerations.cpp OrthancFramework/Sources/Enumerations.h OrthancServer/Resources/Configuration.json OrthancServer/UnitTestsSources/ServerJobsTests.cpp OrthancServer/UnitTestsSources/UnitTestsMain.cpp
diffstat 5 files changed, 4 insertions(+), 14 deletions(-) [+]
line wrap: on
line diff
--- a/OrthancFramework/Sources/Enumerations.cpp	Thu Sep 03 12:00:35 2020 +0200
+++ b/OrthancFramework/Sources/Enumerations.cpp	Thu Sep 03 18:43:18 2020 +0200
@@ -797,9 +797,6 @@
       case ModalityManufacturer_GenericNoUniversalWildcard:
         return "GenericNoUniversalWildcard";
 
-      case ModalityManufacturer_StoreScp:
-        return "StoreScp";
-      
       case ModalityManufacturer_Vitrea:
         return "Vitrea";
       
@@ -1551,10 +1548,6 @@
     {
       return ModalityManufacturer_GenericNoUniversalWildcard;
     }
-    else if (manufacturer == "StoreScp")
-    {
-      return ModalityManufacturer_StoreScp;
-    }
     else if (manufacturer == "Vitrea")
     {
       return ModalityManufacturer_Vitrea;
--- a/OrthancFramework/Sources/Enumerations.h	Thu Sep 03 12:00:35 2020 +0200
+++ b/OrthancFramework/Sources/Enumerations.h	Thu Sep 03 18:43:18 2020 +0200
@@ -645,7 +645,6 @@
     ModalityManufacturer_Generic,
     ModalityManufacturer_GenericNoWildcardInDates,
     ModalityManufacturer_GenericNoUniversalWildcard,
-    ModalityManufacturer_StoreScp,
     ModalityManufacturer_Vitrea,
     ModalityManufacturer_GE
   };
--- a/OrthancServer/Resources/Configuration.json	Thu Sep 03 12:00:35 2020 +0200
+++ b/OrthancServer/Resources/Configuration.json	Thu Sep 03 18:43:18 2020 +0200
@@ -194,7 +194,6 @@
      *   in outgoing C-Find requests originating from Orthanc),
      * - "GenericNoUniversalWildcard" (to replace "*" by "" in all fields
      *   in outgoing C-Find SCU requests originating from Orthanc),
-     * - "StoreScp" (storescp tool from DCMTK),
      * - "Vitrea",
      * - "GE" (Enterprise Archive, MRI consoles and Advantage Workstation
      *   from GE Healthcare).
--- a/OrthancServer/UnitTestsSources/ServerJobsTests.cpp	Thu Sep 03 12:00:35 2020 +0200
+++ b/OrthancServer/UnitTestsSources/ServerJobsTests.cpp	Thu Sep 03 18:43:18 2020 +0200
@@ -618,7 +618,7 @@
       modality.SetApplicationEntityTitle("REMOTE");
       modality.SetHost("192.168.1.1");
       modality.SetPortNumber(1000);
-      modality.SetManufacturer(ModalityManufacturer_StoreScp);
+      modality.SetManufacturer(ModalityManufacturer_GE);
 
       StoreScuOperation operation(GetContext(), luaManager, "TEST", modality);
 
@@ -633,7 +633,7 @@
       ASSERT_EQ("REMOTE", tmp.GetRemoteModality().GetApplicationEntityTitle());
       ASSERT_EQ("192.168.1.1", tmp.GetRemoteModality().GetHost());
       ASSERT_EQ(1000, tmp.GetRemoteModality().GetPortNumber());
-      ASSERT_EQ(ModalityManufacturer_StoreScp, tmp.GetRemoteModality().GetManufacturer());
+      ASSERT_EQ(ModalityManufacturer_GE, tmp.GetRemoteModality().GetManufacturer());
       ASSERT_EQ("TEST", tmp.GetLocalAet());
     }
   }
@@ -704,7 +704,7 @@
     modality.SetApplicationEntityTitle("REMOTE");
     modality.SetHost("192.168.1.1");
     modality.SetPortNumber(1000);
-    modality.SetManufacturer(ModalityManufacturer_StoreScp);
+    modality.SetManufacturer(ModalityManufacturer_GE);
 
     DicomModalityStoreJob job(GetContext());
     job.SetLocalAet("LOCAL");
@@ -724,7 +724,7 @@
     ASSERT_EQ("REMOTE", tmp.GetParameters().GetRemoteModality().GetApplicationEntityTitle());
     ASSERT_EQ("192.168.1.1", tmp.GetParameters().GetRemoteModality().GetHost());
     ASSERT_EQ(1000, tmp.GetParameters().GetRemoteModality().GetPortNumber());
-    ASSERT_EQ(ModalityManufacturer_StoreScp, tmp.GetParameters().GetRemoteModality().GetManufacturer());
+    ASSERT_EQ(ModalityManufacturer_GE, tmp.GetParameters().GetRemoteModality().GetManufacturer());
     ASSERT_TRUE(tmp.HasMoveOriginator());
     ASSERT_EQ("MOVESCU", tmp.GetMoveOriginatorAet());
     ASSERT_EQ(42, tmp.GetMoveOriginatorId());
--- a/OrthancServer/UnitTestsSources/UnitTestsMain.cpp	Thu Sep 03 12:00:35 2020 +0200
+++ b/OrthancServer/UnitTestsSources/UnitTestsMain.cpp	Thu Sep 03 18:43:18 2020 +0200
@@ -117,7 +117,6 @@
   ASSERT_STREQ("Generic", EnumerationToString(StringToModalityManufacturer("Generic")));
   ASSERT_STREQ("GenericNoWildcardInDates", EnumerationToString(StringToModalityManufacturer("GenericNoWildcardInDates")));
   ASSERT_STREQ("GenericNoUniversalWildcard", EnumerationToString(StringToModalityManufacturer("GenericNoUniversalWildcard")));
-  ASSERT_STREQ("StoreScp", EnumerationToString(StringToModalityManufacturer("StoreScp")));
   ASSERT_STREQ("Vitrea", EnumerationToString(StringToModalityManufacturer("Vitrea")));
   ASSERT_STREQ("GE", EnumerationToString(StringToModalityManufacturer("GE")));
   // backward compatibility tests (to remove once we make these manufacturer really obsolete)