# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1786714970 -7200
# Node ID f649f7091dabd0ba7091f64394fb4c98966bd14e
# Parent  c9b580d5ef03122afd614334fbf4ab13931815a5
cppcheck

diff -r c9b580d5ef03 -r f649f7091dab OrthancFramework/UnitTestsSources/DataSourceTests.cpp
--- a/OrthancFramework/UnitTestsSources/DataSourceTests.cpp	Fri Aug 14 15:36:16 2026 +0200
+++ b/OrthancFramework/UnitTestsSources/DataSourceTests.cpp	Fri Aug 14 15:42:50 2026 +0200
@@ -193,8 +193,6 @@
   }
 
   {
-    DataSourceReader reader(service, new IntegerDataSource);
-
     boost::shared_ptr<DataSourceAnswer> answer;
 
     std::unique_ptr<DataSourceRequest> request(new DataSourceRequest);
@@ -232,8 +230,6 @@
   }
 
   {
-    DataSourceReader reader(service, new IntegerDataSource);
-
     boost::shared_ptr<DataSourceAnswer> answer;
 
     std::unique_ptr<DataSourceRequest> request(new DataSourceRequest);
@@ -305,6 +301,8 @@
   serviceSource->SetDequeueTimeout(5);  // Stop the test fast
   serviceSource->Start();
 
+  boost::shared_ptr<DataSourceReader> reader(new DataSourceReader(serviceSource, new IntegerDataSource));
+
   boost::shared_ptr<ThreadPool> serviceSequential(new ThreadPool);
   serviceSequential->SetLoggingThreadName("SEQ");
   serviceSequential->SetThreadsCount(1);
@@ -312,8 +310,6 @@
   serviceSequential->Start();
 
   {
-    boost::shared_ptr<DataSourceReader> reader(new DataSourceReader(serviceSource, new IntegerDataSource));
-
     DataSourceSequentialReader seq(serviceSequential, reader, new IntegerDisconnector, 4, 0);
 
     for (int i = 0; i < 10; i++)
@@ -340,8 +336,6 @@
   }
 
   {
-    boost::shared_ptr<DataSourceReader> reader(new DataSourceReader(serviceSource, new IntegerDataSource));
-
     DataSourceSequentialReader seq(serviceSequential, reader, new IntegerDisconnector, 4, 0);
 
     for (int i = 0; i < 100; i++)