# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1687947892 -7200
# Node ID f41e1f635c4db6198f95022f1200594f1fedcd2b
# Parent  cba09fd1e234ac3dd29d8cac3048e1f1056ef543
cppcheck

diff -r cba09fd1e234 -r f41e1f635c4d OrthancFramework/Sources/HttpServer/HttpContentNegociation.cpp
--- a/OrthancFramework/Sources/HttpServer/HttpContentNegociation.cpp	Wed Jun 28 12:16:54 2023 +0200
+++ b/OrthancFramework/Sources/HttpServer/HttpContentNegociation.cpp	Wed Jun 28 12:24:52 2023 +0200
@@ -231,7 +231,6 @@
     Toolbox::TokenizeString(mediaRanges, accept, ',');
 
     std::unique_ptr<Reference> bestMatch;
-    Dictionary bestParameters;
 
     for (Tokens::const_iterator it = mediaRanges.begin();
          it != mediaRanges.end(); ++it)
diff -r cba09fd1e234 -r f41e1f635c4d OrthancFramework/Sources/MetricsRegistry.cpp
--- a/OrthancFramework/Sources/MetricsRegistry.cpp	Wed Jun 28 12:16:54 2023 +0200
+++ b/OrthancFramework/Sources/MetricsRegistry.cpp	Wed Jun 28 12:24:52 2023 +0200
@@ -186,7 +186,7 @@
     MetricsUpdatePolicy   policy_;
     
   public:
-    Item(MetricsUpdatePolicy policy) :
+    explicit Item(MetricsUpdatePolicy policy) :
       policy_(policy)
     {
     }
@@ -222,7 +222,7 @@
     TimestampedValue<float>  value_;
 
   public:
-    FloatItem(MetricsUpdatePolicy policy) :
+    explicit FloatItem(MetricsUpdatePolicy policy) :
       Item(policy)
     {
     }
@@ -270,7 +270,7 @@
     TimestampedValue<int64_t>  value_;
 
   public:
-    IntegerItem(MetricsUpdatePolicy policy) :
+    explicit IntegerItem(MetricsUpdatePolicy policy) :
       Item(policy)
     {
     }
diff -r cba09fd1e234 -r f41e1f635c4d OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp
--- a/OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp	Wed Jun 28 12:16:54 2023 +0200
+++ b/OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp	Wed Jun 28 12:24:52 2023 +0200
@@ -222,7 +222,7 @@
     catch (OrthancException& e)
     {
       LOG(WARNING) << "An error occurred while executing a Modification job on instance " << instance << ": " << e.GetDetails();
-      throw e;
+      throw;
     }