# HG changeset patch
# User Alain Mazy <am@orthanc.team>
# Date 1726305851 -7200
# Node ID f1ccb67fce31ecabf63c44909436251348654808
# Parent  dc06dbca0d32fe03252cc54ea566624e08469625
fix

diff -r dc06dbca0d32 -r f1ccb67fce31 OrthancServer/Plugins/Engine/OrthancPluginDatabaseV4.cpp
--- a/OrthancServer/Plugins/Engine/OrthancPluginDatabaseV4.cpp	Fri Sep 13 17:33:38 2024 +0200
+++ b/OrthancServer/Plugins/Engine/OrthancPluginDatabaseV4.cpp	Sat Sep 14 11:24:11 2024 +0200
@@ -1570,7 +1570,7 @@
 
             for (int i = 0; i < source.one_instance_attachments().size(); i++)
             {
-              FileInfo info(Convert(source.attachments(i)));
+              FileInfo info(Convert(source.one_instance_attachments(i)));
               if (attachments.find(info.GetContentType()) == attachments.end())
               {
                 attachments[info.GetContentType()] = info;
diff -r dc06dbca0d32 -r f1ccb67fce31 OrthancServer/Sources/Database/SQLiteDatabaseWrapper.cpp
--- a/OrthancServer/Sources/Database/SQLiteDatabaseWrapper.cpp	Fri Sep 13 17:33:38 2024 +0200
+++ b/OrthancServer/Sources/Database/SQLiteDatabaseWrapper.cpp	Sat Sep 14 11:24:11 2024 +0200
@@ -438,7 +438,7 @@
         LookupFormatter formatter;
         LookupFormatter::Apply(sql, formatter, request);
 
-        sql = "CREATE TEMPORARY TABLE Lookup AS " + sql;
+        sql = "CREATE TEMPORARY TABLE Lookup AS " + sql;   // TODO-FIND: use a CTE
 
         SQLite::Statement statement(db_, sql);
         formatter.Bind(statement);
@@ -595,11 +595,12 @@
         }
       }
 
+      // need one instance info ?
       if (request.GetLevel() != ResourceType_Instance &&
           request.IsRetrieveOneInstanceMetadataAndAttachments())
       {
         {
-          SQLite::Statement s(db_, SQLITE_FROM_HERE, "DROP TABLE IF EXISTS OneInstance");
+          SQLite::Statement s(db_, SQLITE_FROM_HERE, "DROP TABLE IF EXISTS OneInstance");  // TODO-FIND: use a CTE
           s.Run();
         }