# HG changeset patch # User Sebastien Jodogne # Date 1587397151 -7200 # Node ID ee0a1211419f2fce33f7ecb8d4b4f26f804e6abf # Parent 6498739a3c3c4b9f76b6e79b2fe0b448bd5c97aa reverting default HttpThreadsCount to 50, as this slows performance of integration tests from 40s to 170s diff -r 6498739a3c3c -r ee0a1211419f NEWS --- a/NEWS Mon Apr 20 16:46:44 2020 +0200 +++ b/NEWS Mon Apr 20 17:39:11 2020 +0200 @@ -34,7 +34,6 @@ * Error reporting on failure while initializing SSL * Fix unit test ParsedDicomFile.ToJsonFlags2 on big-endian architectures * Avoid one memcpy of the DICOM buffer on "POST /instances" -* Default value of "HttpThreadsCount" reduced from 50 to 10 * Upgraded dependencies for static builds (notably on Windows): - civetweb 1.12 - openssl 1.1.1f diff -r 6498739a3c3c -r ee0a1211419f OrthancServer/main.cpp --- a/OrthancServer/main.cpp Mon Apr 20 16:46:44 2020 +0200 +++ b/OrthancServer/main.cpp Mon Apr 20 17:39:11 2020 +0200 @@ -906,7 +906,7 @@ httpDescribeErrors = lock.GetConfiguration().GetBooleanParameter("HttpDescribeErrors", true); // HTTP server - httpServer.SetThreadsCount(lock.GetConfiguration().GetUnsignedIntegerParameter("HttpThreadsCount", 10)); + httpServer.SetThreadsCount(lock.GetConfiguration().GetUnsignedIntegerParameter("HttpThreadsCount", 50)); httpServer.SetPortNumber(lock.GetConfiguration().GetUnsignedIntegerParameter("HttpPort", 8042)); httpServer.SetRemoteAccessAllowed(lock.GetConfiguration().GetBooleanParameter("RemoteAccessAllowed", false)); httpServer.SetKeepAliveEnabled(lock.GetConfiguration().GetBooleanParameter("KeepAlive", defaultKeepAlive)); diff -r 6498739a3c3c -r ee0a1211419f Resources/Configuration.json --- a/Resources/Configuration.json Mon Apr 20 16:46:44 2020 +0200 +++ b/Resources/Configuration.json Mon Apr 20 17:39:11 2020 +0200 @@ -391,11 +391,8 @@ // caveats: https://eklitzke.org/the-caveats-of-tcp-nodelay "TcpNoDelay" : true, - // Number of threads that are used by the embedded HTTP server. In - // Orthanc <= 1.6.0, the default value was 50. In Orthanc >= 1.6.1, - // default is 10 to prevent memory grow in basic setups. - // https://groups.google.com/d/msg/orthanc-users/qWqxpvCPv8g/Z8huoA5FDAAJ - "HttpThreadsCount" : 10, + // Number of threads that are used by the embedded HTTP server. + "HttpThreadsCount" : 50, // If this option is set to "false", Orthanc will run in index-only // mode. The DICOM files will not be stored on the drive. Note that