# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1592410785 -7200
# Node ID ea95eecead6f328766716bfe54cc1e37a449ba99
# Parent  7116e34221fe203899d9d8ba54acb9b864618cad
notes

diff -r 7116e34221fe -r ea95eecead6f OrthancFramework/Resources/CMake/EmscriptenParameters.cmake
--- a/OrthancFramework/Resources/CMake/EmscriptenParameters.cmake	Mon Jun 15 17:22:19 2020 +0200
+++ b/OrthancFramework/Resources/CMake/EmscriptenParameters.cmake	Wed Jun 17 18:19:45 2020 +0200
@@ -1,8 +1,14 @@
+# https://github.com/emscripten-core/emscripten/blob/master/src/settings.js
+
 if (NOT "${EMSCRIPTEN_TRAP_MODE}" STREQUAL "")
   set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -s BINARYEN_TRAP_MODE='\"${EMSCRIPTEN_TRAP_MODE}\"'")
 endif()
 
+# "DISABLE_EXCEPTION_CATCHING" is a "compile+link" option. HOWEVER,
+# setting it inside "WASM_FLAGS" creates link errors, at least with
+# side modules. TODO: Understand why
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -s DISABLE_EXCEPTION_CATCHING=0")
+#set(WASM_FLAGS "${WASM_FLAGS} -s DISABLE_EXCEPTION_CATCHING=0")
 
 if (EMSCRIPTEN_TARGET_MODE STREQUAL "wasm")
   # WebAssembly