# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1644437277 -3600
# Node ID d7d5d63985c8fbdd72f8ee73a91cf03be68e14c1
# Parent  504624b0a0628caf56dd82da0e5ea850b8680a1b
allow custom value for "Modality" in /tools/create-dicom for PDF

diff -r 504624b0a062 -r d7d5d63985c8 OrthancFramework/Sources/DicomParsing/ParsedDicomFile.cpp
--- a/OrthancFramework/Sources/DicomParsing/ParsedDicomFile.cpp	Wed Feb 09 13:10:11 2022 +0100
+++ b/OrthancFramework/Sources/DicomParsing/ParsedDicomFile.cpp	Wed Feb 09 21:07:57 2022 +0100
@@ -1502,11 +1502,14 @@
 
     InvalidateCache();
 
+    // In Orthanc <= 1.9.7, the "Modality" would have always be overwritten as "OT"
+    // https://groups.google.com/g/orthanc-users/c/eNSddNrQDtM/m/wc1HahimAAAJ
+    
     ReplacePlainString(DICOM_TAG_SOP_CLASS_UID, UID_EncapsulatedPDFStorage);
-    ReplacePlainString(FromDcmtkBridge::Convert(DCM_Modality), "OT");
-    ReplacePlainString(FromDcmtkBridge::Convert(DCM_ConversionType), "WSD");
-    ReplacePlainString(FromDcmtkBridge::Convert(DCM_MIMETypeOfEncapsulatedDocument), MIME_PDF);
-    //ReplacePlainString(FromDcmtkBridge::Convert(DCM_SeriesNumber), "1");
+    SetIfAbsent(FromDcmtkBridge::Convert(DCM_Modality), "OT");
+    SetIfAbsent(FromDcmtkBridge::Convert(DCM_ConversionType), "WSD");
+    SetIfAbsent(FromDcmtkBridge::Convert(DCM_MIMETypeOfEncapsulatedDocument), MIME_PDF);
+    //SetIfAbsent(FromDcmtkBridge::Convert(DCM_SeriesNumber), "1");
 
     std::unique_ptr<DcmPolymorphOBOW> element(new DcmPolymorphOBOW(DCM_EncapsulatedDocument));