# HG changeset patch # User s.jodogne@gmail.com # Date 1531478093 -7200 # Node ID cb1b26a7db988777fe2a018923c7c0d227002f58 # Parent cdf13d06cf40cf1b569a6b04bbc65ea3006f9da8 fix mingw compilation diff -r cdf13d06cf40 -r cb1b26a7db98 OrthancServer/ServerJobs/ArchiveJob.cpp --- a/OrthancServer/ServerJobs/ArchiveJob.cpp Fri Jul 13 10:07:45 2018 +0200 +++ b/OrthancServer/ServerJobs/ArchiveJob.cpp Fri Jul 13 12:34:53 2018 +0200 @@ -844,7 +844,7 @@ if (writer_->GetStepsCount() == 0) { - writer_.reset(NULL); // Flush all the results + writer_.reset(); // Flush all the results return JobStepResult::Success(); } else @@ -855,7 +855,7 @@ if (currentStep_ == writer_->GetStepsCount()) { - writer_.reset(NULL); // Flush all the results + writer_.reset(); // Flush all the results return JobStepResult::Success(); } else diff -r cdf13d06cf40 -r cb1b26a7db98 OrthancServer/ServerJobs/ArchiveJob.h --- a/OrthancServer/ServerJobs/ArchiveJob.h Fri Jul 13 10:07:45 2018 +0200 +++ b/OrthancServer/ServerJobs/ArchiveJob.h Fri Jul 13 12:34:53 2018 +0200 @@ -51,17 +51,17 @@ class ZipWriterIterator; class ZipWriterIterator; - boost::shared_ptr target_; - ServerContext& context_; - std::auto_ptr archive_; - bool isMedia_; - bool enableExtendedSopClass_; - std::string description_; + boost::shared_ptr target_; + ServerContext& context_; + boost::shared_ptr archive_; + bool isMedia_; + bool enableExtendedSopClass_; + std::string description_; - std::auto_ptr writer_; - size_t currentStep_; - unsigned int instancesCount_; - uint64_t uncompressedSize_; + boost::shared_ptr writer_; + size_t currentStep_; + unsigned int instancesCount_; + uint64_t uncompressedSize_; public: ArchiveJob(boost::shared_ptr& target, diff -r cdf13d06cf40 -r cb1b26a7db98 OrthancServer/ServerJobs/LuaJobManager.cpp --- a/OrthancServer/ServerJobs/LuaJobManager.cpp Fri Jul 13 10:07:45 2018 +0200 +++ b/OrthancServer/ServerJobs/LuaJobManager.cpp Fri Jul 13 12:34:53 2018 +0200 @@ -238,7 +238,8 @@ void LuaJobManager::Lock::AddNullInput(size_t operation) { assert(jobLock_.get() != NULL); - jobLock_->AddInput(operation, NullOperationValue()); + NullOperationValue null; + jobLock_->AddInput(operation, null); } @@ -246,7 +247,8 @@ const std::string& content) { assert(jobLock_.get() != NULL); - jobLock_->AddInput(operation, StringOperationValue(content)); + StringOperationValue value(content); + jobLock_->AddInput(operation, value); } @@ -255,7 +257,8 @@ const std::string& instanceId) { assert(jobLock_.get() != NULL); - jobLock_->AddInput(operation, DicomInstanceOperationValue(context, instanceId)); + DicomInstanceOperationValue value(context, instanceId); + jobLock_->AddInput(operation, value); } diff -r cdf13d06cf40 -r cb1b26a7db98 UnitTestsSources/MultiThreadingTests.cpp --- a/UnitTestsSources/MultiThreadingTests.cpp Fri Jul 13 10:07:45 2018 +0200 +++ b/UnitTestsSources/MultiThreadingTests.cpp Fri Jul 13 12:34:53 2018 +0200 @@ -707,8 +707,12 @@ size_t i = lock.AddOperation(new LogJobOperation); size_t j = lock.AddOperation(new LogJobOperation); size_t k = lock.AddOperation(new LogJobOperation); - lock.AddInput(i, StringOperationValue("Hello")); - lock.AddInput(i, StringOperationValue("World")); + + StringOperationValue a("Hello"); + StringOperationValue b("World"); + lock.AddInput(i, a); + lock.AddInput(i, b); + lock.Connect(i, j); lock.Connect(j, k); } @@ -1002,8 +1006,11 @@ size_t a = lock.AddOperation(new LogJobOperation); size_t b = lock.AddOperation(new LogJobOperation); lock.Connect(a, b); - lock.AddInput(a, StringOperationValue("hello")); - lock.AddInput(a, StringOperationValue("world")); + + StringOperationValue s1("hello"); + StringOperationValue s2("world"); + lock.AddInput(a, s1); + lock.AddInput(a, s2); lock.SetDicomAssociationTimeout(200); lock.SetTrailingOperationTimeout(300); }