# HG changeset patch
# User Alain Mazy <am@orthanc.team>
# Date 1740051382 -3600
# Node ID caa47124773520c39ae89aabe1a246eee8506509
# Parent  6f6888ab5e5c3b3c0334293356291a009ac1fdf9
SQLite: tools/find is now returning results when e.g, ordering instances against a metadata they don't have

diff -r 6f6888ab5e5c -r caa471247735 NEWS
--- a/NEWS	Thu Feb 20 11:52:25 2025 +0100
+++ b/NEWS	Thu Feb 20 12:36:22 2025 +0100
@@ -13,7 +13,9 @@
 Maintenance
 -----------
 
-* In the "ExtendedFind" mode, optimized "tools/find" when "StorageAccessMode" is set to "Never".
+* In the "ExtendedFind" mode:
+  - optimized "tools/find" when "StorageAccessMode" is set to "Never".
+  - "tools/find" is now returning results when e.g, ordering instances against a metadata they don't have
 * Fixed interpretation of returnUnsupportedImage in /preview route. 
 * GET /series/../study now also contain LastUpdate field:
   https://discourse.orthanc-server.org/t/lastupdate-coherency/5524
diff -r 6f6888ab5e5c -r caa471247735 OrthancServer/Sources/Search/ISqlLookupFormatter.cpp
--- a/OrthancServer/Sources/Search/ISqlLookupFormatter.cpp	Thu Feb 20 11:52:25 2025 +0100
+++ b/OrthancServer/Sources/Search/ISqlLookupFormatter.cpp	Thu Feb 20 12:36:22 2025 +0100
@@ -373,7 +373,7 @@
     std::string arg = "order" + boost::lexical_cast<std::string>(index);
 
 
-    target = " INNER JOIN Metadata " + arg + " ON " + arg + ".id = " + FormatLevel(requestLevel) +
+    target = " LEFT JOIN Metadata " + arg + " ON " + arg + ".id = " + FormatLevel(requestLevel) +
              ".internalId AND " + arg + ".type = " +
              boost::lexical_cast<std::string>(metadata);
   }