# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1550152591 -3600
# Node ID c85510b5f21d461d6234858f520ac138751581c1
# Parent  6399f5f254980dfd076c85516ca75c0577efe721
unit testing ParsedDicomFile::DetectEncoding()

diff -r 6399f5f25498 -r c85510b5f21d UnitTestsSources/FromDcmtkTests.cpp
--- a/UnitTestsSources/FromDcmtkTests.cpp	Thu Feb 14 14:48:43 2019 +0100
+++ b/UnitTestsSources/FromDcmtkTests.cpp	Thu Feb 14 14:56:31 2019 +0100
@@ -1544,6 +1544,11 @@
   ASSERT_TRUE(dicom.GetDcmtkObject().getDataset()->putAndInsertString
               (DCM_PatientName, korean.c_str(), korean.size(), true).good());
 
+  bool hasCodeExtensions;
+  Encoding encoding = dicom.DetectEncoding(hasCodeExtensions);
+  ASSERT_EQ(Encoding_Korean, encoding);
+  ASSERT_TRUE(hasCodeExtensions);
+  
   std::string value;
   ASSERT_TRUE(dicom.GetTagValue(value, DICOM_TAG_PATIENT_NAME));
   ASSERT_EQ(utf8, value);
@@ -1593,7 +1598,7 @@
 
 
 
-TEST(Toolbox, EncodingsJapanese)
+TEST(Toolbox, EncodingsJapaneseKanji)
 {
   // http://dicom.nema.org/MEDICAL/dicom/2017c/output/chtml/part05/sect_H.3.html
 
@@ -1620,6 +1625,11 @@
   ASSERT_TRUE(dicom.GetDcmtkObject().getDataset()->putAndInsertString
               (DCM_PatientName, japanese.c_str(), japanese.size(), true).good());
 
+  bool hasCodeExtensions;
+  Encoding encoding = dicom.DetectEncoding(hasCodeExtensions);
+  ASSERT_EQ(Encoding_JapaneseKanji, encoding);
+  ASSERT_TRUE(hasCodeExtensions);
+
   std::string value;
   ASSERT_TRUE(dicom.GetTagValue(value, DICOM_TAG_PATIENT_NAME));
   ASSERT_EQ(utf8, value);
@@ -1683,6 +1693,11 @@
   ASSERT_TRUE(dicom.GetDcmtkObject().getDataset()->putAndInsertString
               (DCM_PatientName, reinterpret_cast<const char*>(chinese), sizeof(chinese), true).good());
 
+  bool hasCodeExtensions;
+  Encoding encoding = dicom.DetectEncoding(hasCodeExtensions);
+  ASSERT_EQ(Encoding_Chinese, encoding);
+  ASSERT_FALSE(hasCodeExtensions);
+
   std::string value;
   ASSERT_TRUE(dicom.GetTagValue(value, DICOM_TAG_PATIENT_NAME));
 
@@ -1740,6 +1755,11 @@
   ASSERT_TRUE(dicom.GetDcmtkObject().getDataset()->putAndInsertString
               (DCM_PatientComments, reinterpret_cast<const char*>(chinese), sizeof(chinese), true).good());
 
+  bool hasCodeExtensions;
+  Encoding encoding = dicom.DetectEncoding(hasCodeExtensions);
+  ASSERT_EQ(Encoding_Chinese, encoding);
+  ASSERT_FALSE(hasCodeExtensions);
+
   std::string value;
   ASSERT_TRUE(dicom.GetTagValue(value, DICOM_TAG_PATIENT_COMMENTS));