# HG changeset patch
# User Alain Mazy <am@orthanc.team>
# Date 1733766560 -3600
# Node ID bb059b09f73ce698f1f4aef38d982d79a90b8cf2
# Parent  f7fcf8b102d3c7a23738cc7c8d269f12deb1baaa
cleanup

diff -r f7fcf8b102d3 -r bb059b09f73c OrthancFramework/Sources/DicomNetworking/DicomControlUserConnection.cpp
--- a/OrthancFramework/Sources/DicomNetworking/DicomControlUserConnection.cpp	Mon Dec 09 16:54:56 2024 +0100
+++ b/OrthancFramework/Sources/DicomNetworking/DicomControlUserConnection.cpp	Mon Dec 09 18:49:20 2024 +0100
@@ -543,7 +543,7 @@
         sopClass = UID_GETStudyRootQueryRetrieveInformationModel;
         break;
       default:
-        throw OrthancException(ErrorCode_InternalError); // TODO-GET: implement series + instances
+        throw OrthancException(ErrorCode_InternalError);
     }
 
     // Figure out which of the accepted presentation contexts should be used
@@ -662,8 +662,8 @@
 
           if (result.bad())
           {
+            LOG(WARNING) << "C-GET SCU handler: Failed to receive dataset: " << result.text();
             desiredCStoreReturnStatus = STATUS_STORE_Error_CannotUnderstand;
-            // TODO-GET: return ?
           }
           else
           {
diff -r f7fcf8b102d3 -r bb059b09f73c OrthancServer/Resources/Configuration.json
--- a/OrthancServer/Resources/Configuration.json	Mon Dec 09 16:54:56 2024 +0100
+++ b/OrthancServer/Resources/Configuration.json	Mon Dec 09 18:49:20 2024 +0100
@@ -220,7 +220,7 @@
   // The list of rejected Storage SOP classes.
   // This configuration is only meaningful if
   // "AcceptedSopClasses" is using regular expressions
-  // or if it not defined.
+  // or if it is not defined.
   // Each entry can contain wildcards ("?" or "*").
   // (new in Orthanc 1.12.6)
   // "RejectedSopClasses" : [
diff -r f7fcf8b102d3 -r bb059b09f73c TODO
--- a/TODO	Mon Dec 09 16:54:56 2024 +0100
+++ b/TODO	Mon Dec 09 18:49:20 2024 +0100
@@ -186,9 +186,6 @@
 Mid-term
 --------
 
-* Support C-GET SCU (note that C-GET SCP was introduced in Orthanc 1.7.0)
-* Configure the list of accepted SOP Classes
-  https://discourse.orthanc-server.org/t/can-you-limit-the-sop-classes-accepted-as-store-scp/4606
 * Check how Orthanc shall behave wrt to AcceptedSopClasses in these situations (consider Orthanc
   accepts CT but not PT)
   - What shall we log/warn if an external modality tries to send a PT/CT
@@ -204,9 +201,6 @@
 * Strict hierarchical C-FIND:
   https://groups.google.com/d/msg/orthanc-users/VBHpeGVSNKM/tkaVvjWFBwAJ
 * report DIMSE error codes in Rest API and job status for /store /query /move /retrieve
-* report progress report of C-Move operation in jop progress.  There are 
-  progress callbacks available in DIMSE_moveUser
-  https://groups.google.com/g/orthanc-users/c/c8cGnA7FzsE/m/BSs66D8wBwAJ
 * Log outgoing C-Find queries
 * Support other Transfer Syntaxes in the Worklist plugin:
   https://discourse.orthanc-server.org/t/could-you-please-create-an-option-to-set-the-transfer-syntax-in-the-worklist-plugin-currently-little-endian-explicit-is-fixed/4871