# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1669210130 -3600
# Node ID a3c3f13368ea951c8d92c304e4ab3559d8f396b7
# Parent  b89833d7ce223e73e3db1ee3b93a87f8ee1fbf9b
clarification that "image/jpg" is not a correct MIME type

diff -r b89833d7ce22 -r a3c3f13368ea NEWS
--- a/NEWS	Wed Nov 23 11:47:44 2022 +0100
+++ b/NEWS	Wed Nov 23 14:28:50 2022 +0100
@@ -25,7 +25,7 @@
 * /modalities/.../store now accepts "CalledAet", "Host", "Port" to override the modality configuration 
   from the configuration file for a specific operation.
 * /tools/metrics-prometheus: added orthanc_last_change and orthanc_up_time_s
-* Fix support for image/jpg mime type in /tools/create-dicom
+* Tolerance for "image/jpg" MIME type instead of "image/jpeg" in /tools/create-dicom
 
 
 OrthancFramework (C++)
diff -r b89833d7ce22 -r a3c3f13368ea OrthancFramework/Sources/Enumerations.cpp
--- a/OrthancFramework/Sources/Enumerations.cpp	Wed Nov 23 11:47:44 2022 +0100
+++ b/OrthancFramework/Sources/Enumerations.cpp	Wed Nov 23 14:28:50 2022 +0100
@@ -1728,8 +1728,12 @@
       target = MimeType_Dicom;
       return true;
     }
-    else if (source == MIME_JPEG || source == MIME_JPG)
+    else if (source == MIME_JPEG ||
+             source == "image/jpg")
     {
+      // Note the tolerance for "image/jpg", which is *not* a standard MIME type
+      // https://groups.google.com/g/orthanc-users/c/Y5x37UFKiDg/m/1zI260KTAwAJ
+      // https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types
       target = MimeType_Jpeg;
       return true;
     }
diff -r b89833d7ce22 -r a3c3f13368ea OrthancFramework/Sources/Enumerations.h
--- a/OrthancFramework/Sources/Enumerations.h	Wed Nov 23 11:47:44 2022 +0100
+++ b/OrthancFramework/Sources/Enumerations.h	Wed Nov 23 14:28:50 2022 +0100
@@ -35,7 +35,6 @@
 
   static const char* const MIME_BINARY = "application/octet-stream";
   static const char* const MIME_JPEG = "image/jpeg";
-  static const char* const MIME_JPG = "image/jpg";
   static const char* const MIME_JSON = "application/json";
   static const char* const MIME_JSON_UTF8 = "application/json; charset=utf-8";
   static const char* const MIME_PDF = "application/pdf";