# HG changeset patch # User Benjamin Golinvaux # Date 1558075344 -7200 # Node ID 974e12006b7ddbf1e1f2b656ccd30bebab0686a7 # Parent 596cfabd72c5dc9851572b00cbb1ec216fbcfc11 Removed extern "C" qualifier around function that is internally linked (extern "C" having thus no effect) AND throws exceptions (thus may NOT be extern "C"). diff -r 596cfabd72c5 -r 974e12006b7d Core/HttpClient.cpp --- a/Core/HttpClient.cpp Fri May 17 08:36:18 2019 +0200 +++ b/Core/HttpClient.cpp Fri May 17 08:42:24 2019 +0200 @@ -68,22 +68,22 @@ return code; } } +} - // This is a dummy wrapper function to suppress any OpenSSL-related - // problem in valgrind. Inlining is prevented. +// This is a dummy wrapper function to suppress any OpenSSL-related +// problem in valgrind. Inlining is prevented. #if defined(__GNUC__) || defined(__clang__) - __attribute__((noinline)) + __attribute__((noinline)) #endif - static CURLcode OrthancHttpClientPerformSSL(CURL* curl, long* status) - { +static CURLcode OrthancHttpClientPerformSSL(CURL* curl, long* status) +{ #if ORTHANC_ENABLE_SSL == 1 - return GetHttpStatus(curl_easy_perform(curl), curl, status); + return GetHttpStatus(curl_easy_perform(curl), curl, status); #else - throw Orthanc::OrthancException(Orthanc::ErrorCode_InternalError, - "Orthanc was compiled without SSL support, " - "cannot make HTTPS request"); + throw Orthanc::OrthancException(Orthanc::ErrorCode_InternalError, + "Orthanc was compiled without SSL support, " + "cannot make HTTPS request"); #endif - } }