# HG changeset patch # User Sebastien Jodogne # Date 1423233046 -3600 # Node ID 919dfb2fb3fe95d7ff564b85052b4863758c9197 # Parent 4ce47e8ed0d28bec7fe17cd0459885cdca4429c5 DANGEROUS refactoring diff -r 4ce47e8ed0d2 -r 919dfb2fb3fe OrthancServer/DatabaseWrapper.cpp --- a/OrthancServer/DatabaseWrapper.cpp Fri Feb 06 15:13:05 2015 +0100 +++ b/OrthancServer/DatabaseWrapper.cpp Fri Feb 06 15:30:46 2015 +0100 @@ -573,18 +573,12 @@ void DatabaseWrapper::LogChange(int64_t internalId, const ServerIndexChange& change) { - if (change.GetChangeType() <= ChangeType_INTERNAL_LastLogged) - { - SQLite::Statement s(db_, SQLITE_FROM_HERE, "INSERT INTO Changes VALUES(NULL, ?, ?, ?, ?)"); - s.BindInt(0, change.GetChangeType()); - s.BindInt64(1, internalId); - s.BindInt(2, change.GetResourceType()); - s.BindString(3, change.GetDate()); - s.Run(); - } - - assert(listener_ != NULL); - listener_->SignalChange(change); + SQLite::Statement s(db_, SQLITE_FROM_HERE, "INSERT INTO Changes VALUES(NULL, ?, ?, ?, ?)"); + s.BindInt(0, change.GetChangeType()); + s.BindInt64(1, internalId); + s.BindInt(2, change.GetResourceType()); + s.BindString(3, change.GetDate()); + s.Run(); } diff -r 4ce47e8ed0d2 -r 919dfb2fb3fe OrthancServer/ServerIndex.cpp --- a/OrthancServer/ServerIndex.cpp Fri Feb 06 15:13:05 2015 +0100 +++ b/OrthancServer/ServerIndex.cpp Fri Feb 06 15:30:46 2015 +0100 @@ -447,7 +447,14 @@ const std::string& publicId) { ServerIndexChange change(changeType, resourceType, publicId); - db_.LogChange(internalId, change); + + if (changeType <= ChangeType_INTERNAL_LastLogged) + { + db_.LogChange(internalId, change); + } + + assert(listener_.get() != NULL); + listener_->SignalChange(change); } @@ -522,6 +529,10 @@ ServerIndexChange change(changeType, type, publicId); db_.LogChange(id, change); + + assert(listener_.get() != NULL); + listener_->SignalChange(change); + return id; }