# HG changeset patch # User Sebastien Jodogne # Date 1749657071 -7200 # Node ID 628edb487cec19649d45f9e8ebe53c131e5cada9 # Parent 6b55a6afae69b6ef7edae2ad7df82883ac200a9f fix dangerous cast in OrthancPlugins::MemoryBuffer diff -r 6b55a6afae69 -r 628edb487cec OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp --- a/OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp Wed Jun 11 17:34:05 2025 +0200 +++ b/OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.cpp Wed Jun 11 17:51:11 2025 +0200 @@ -1566,7 +1566,7 @@ { if (!answer.IsEmpty()) { - result.assign(answer.GetData(), answer.GetSize()); + result.assign(reinterpret_cast(answer.GetData()), answer.GetSize()); } return true; } diff -r 6b55a6afae69 -r 628edb487cec OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.h --- a/OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.h Wed Jun 11 17:34:05 2025 +0200 +++ b/OrthancServer/Plugins/Samples/Common/OrthancPluginCppWrapper.h Wed Jun 11 17:51:11 2025 +0200 @@ -227,11 +227,11 @@ OrthancPluginMemoryBuffer Release(); - const char* GetData() const + const void* GetData() const { if (buffer_.size > 0) { - return reinterpret_cast(buffer_.data); + return buffer_.data; } else { diff -r 6b55a6afae69 -r 628edb487cec OrthancServer/Plugins/Samples/ServeFolders/Plugin.cpp --- a/OrthancServer/Plugins/Samples/ServeFolders/Plugin.cpp Wed Jun 11 17:34:05 2025 +0200 +++ b/OrthancServer/Plugins/Samples/ServeFolders/Plugin.cpp Wed Jun 11 17:51:11 2025 +0200 @@ -221,7 +221,7 @@ OrthancPluginSetHttpHeader(OrthancPlugins::GetGlobalContext(), output, "Last-Modified", t.c_str()); - Answer(output, content.GetData(), content.GetSize(), mime); + Answer(output, reinterpret_cast(content.GetData()), content.GetSize(), mime); } } }