# HG changeset patch
# User amazy
# Date 1499938557 -7200
# Node ID 5b7556568fa4e7e1bd62a74f9804971e2031c9c4
# Parent  8bca2c8eaead6cd8c8fc50ec74ca926f676fe5ee
Incoming C-Find request: removing group-length for all manufacturer -> removed EFilm2 manufacturer that is now useless

diff -r 8bca2c8eaead -r 5b7556568fa4 OrthancServer/OrthancFindRequestHandler.cpp
--- a/OrthancServer/OrthancFindRequestHandler.cpp	Wed Jul 12 22:39:28 2017 +0200
+++ b/OrthancServer/OrthancFindRequestHandler.cpp	Thu Jul 13 11:35:57 2017 +0200
@@ -451,19 +451,14 @@
                                                  const DicomTag& tag,
                                                  ModalityManufacturer manufacturer)
   {
+    // wathever the manufacturer, remote the GenericGroupLength tags (http://dicom.nema.org/medical/dicom/current/output/chtml/part05/sect_7.2.html)
+    if (tag.GetGroup() == 0x0000)
+    {
+      return false;
+    }
+
     switch (manufacturer)
     {
-      case ModalityManufacturer_EFilm2:
-        // Following Denis Nesterov's mail on 2015-11-30
-        if (tag == DicomTag(0x0008, 0x0000) ||  // "GenericGroupLength"
-            tag == DicomTag(0x0010, 0x0000) ||  // "GenericGroupLength"
-            tag == DicomTag(0x0020, 0x0000))    // "GenericGroupLength"
-        {
-          return false;
-        }
-
-        break;
-
       case ModalityManufacturer_Vitrea:
         // Following Denis Nesterov's mail on 2015-11-30
         if (tag == DicomTag(0x5653, 0x0010))  // "PrivateCreator = Vital Images SW 3.4"
diff -r 8bca2c8eaead -r 5b7556568fa4 OrthancServer/ServerEnumerations.cpp
--- a/OrthancServer/ServerEnumerations.cpp	Wed Jul 12 22:39:28 2017 +0200
+++ b/OrthancServer/ServerEnumerations.cpp	Thu Jul 13 11:35:57 2017 +0200
@@ -343,9 +343,6 @@
       case ModalityManufacturer_AgfaImpax:
         return "AgfaImpax";
       
-      case ModalityManufacturer_EFilm2:
-        return "EFilm2";
-      
       case ModalityManufacturer_Vitrea:
         return "Vitrea";
       
@@ -422,7 +419,9 @@
     }
     else if (manufacturer == "EFilm2")
     {
-      return ModalityManufacturer_EFilm2;
+      LOG(WARNING) << "The " << manufacturer << " manufacturer is obsolete since Orthanc 1.2.1.  To guarantee compatibility with future Orthanc version, you should remove it from your configuration file.";
+
+      return ModalityManufacturer_Generic;
     }
     else
     {
diff -r 8bca2c8eaead -r 5b7556568fa4 OrthancServer/ServerEnumerations.h
--- a/OrthancServer/ServerEnumerations.h	Wed Jul 12 22:39:28 2017 +0200
+++ b/OrthancServer/ServerEnumerations.h	Thu Jul 13 11:35:57 2017 +0200
@@ -65,7 +65,6 @@
     ModalityManufacturer_Dcm4Chee,
     ModalityManufacturer_SyngoVia,
     ModalityManufacturer_AgfaImpax,
-    ModalityManufacturer_EFilm2,
     ModalityManufacturer_Vitrea
   };