# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1629898954 -7200
# Node ID 248408d2b3364cc24ea8b5e1a2ac973eca4564e8
# Parent  9da6ca57a9772f0841ebd4d50d787683fa33ebe4
hiding FromDcmtkBridge::Apply() on IDicomPathVisitor

diff -r 9da6ca57a977 -r 248408d2b336 OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp
--- a/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp	Wed Aug 25 15:20:48 2021 +0200
+++ b/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.cpp	Wed Aug 25 15:42:34 2021 +0200
@@ -2978,10 +2978,10 @@
   }
 
 
-  static void ApplyInternal(FromDcmtkBridge::IDicomPathVisitor& visitor,
-                            DcmItem& item,
-                            const DicomPath& pattern,
-                            const DicomPath& actualPath)
+  void FromDcmtkBridge::IDicomPathVisitor::ApplyInternal(FromDcmtkBridge::IDicomPathVisitor& visitor,
+                                                         DcmItem& item,
+                                                         const DicomPath& pattern,
+                                                         const DicomPath& actualPath)
   {
     const size_t level = actualPath.GetPrefixLength();
       
@@ -3020,9 +3020,9 @@
   }
 
 
-  void FromDcmtkBridge::Apply(IDicomPathVisitor& visitor,
-                              DcmDataset& dataset,
-                              const DicomPath& path)
+  void FromDcmtkBridge::IDicomPathVisitor::Apply(IDicomPathVisitor& visitor,
+                                                 DcmDataset& dataset,
+                                                 const DicomPath& path)
   {
     DicomPath actualPath(path.GetFinalTag());
     ApplyInternal(visitor, dataset, path, actualPath);
@@ -3044,7 +3044,7 @@
     };
     
     Visitor visitor;
-    Apply(visitor, dataset, path);
+    IDicomPathVisitor::Apply(visitor, dataset, path);
   }
   
 
@@ -3084,7 +3084,7 @@
     };
     
     Visitor visitor(onlyIfExists);
-    Apply(visitor, dataset, path);
+    IDicomPathVisitor::Apply(visitor, dataset, path);
   }
   
 
@@ -3159,7 +3159,7 @@
     else
     {
       Visitor visitor(element, mode);
-      Apply(visitor, dataset, path);
+      IDicomPathVisitor::Apply(visitor, dataset, path);
     }
   }
 }
diff -r 9da6ca57a977 -r 248408d2b336 OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.h
--- a/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.h	Wed Aug 25 15:20:48 2021 +0200
+++ b/OrthancFramework/Sources/DicomParsing/FromDcmtkBridge.h	Wed Aug 25 15:42:34 2021 +0200
@@ -64,6 +64,12 @@
     // New in Orthanc 1.9.4
     class ORTHANC_PUBLIC IDicomPathVisitor : public boost::noncopyable
     {
+    private:
+      static void ApplyInternal(FromDcmtkBridge::IDicomPathVisitor& visitor,
+                                DcmItem& item,
+                                const DicomPath& pattern,
+                                const DicomPath& actualPath);
+      
     public:
       virtual ~IDicomPathVisitor()
       {
@@ -71,6 +77,10 @@
 
       virtual void Visit(DcmItem& item,
                          const DicomPath& path) = 0;
+
+      static void Apply(IDicomPathVisitor& visitor,
+                        DcmDataset& dataset,
+                        const DicomPath& path);
     };
     
 
@@ -256,10 +266,6 @@
 
     static void LogMissingTagsForStore(DcmDataset& dicom);
 
-    static void Apply(IDicomPathVisitor& visitor,
-                      DcmDataset& dataset,
-                      const DicomPath& path);
-
     static void RemovePath(DcmDataset& dataset,
                            const DicomPath& path);