# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1607428532 -3600
# Node ID 18c94a82f3d4f655d716d40f7e1c1006eedba232
# Parent  460a71988208ad7e6c7b9765f29be15262bc01b0
cppcheck

diff -r 460a71988208 -r 18c94a82f3d4 OrthancFramework/Sources/Compression/ZipReader.cpp
--- a/OrthancFramework/Sources/Compression/ZipReader.cpp	Tue Dec 08 12:38:59 2020 +0100
+++ b/OrthancFramework/Sources/Compression/ZipReader.cpp	Tue Dec 08 12:55:32 2020 +0100
@@ -58,7 +58,7 @@
     {
     }
   
-    MemoryBuffer(const std::string& s) :
+    explicit MemoryBuffer(const std::string& s) :
       content_(s.empty() ? NULL : reinterpret_cast<const uint8_t*>(s.c_str())),
       size_(s.size()),
       pos_(0)
diff -r 460a71988208 -r 18c94a82f3d4 OrthancFramework/Sources/Compression/ZipReader.h
--- a/OrthancFramework/Sources/Compression/ZipReader.h	Tue Dec 08 12:38:59 2020 +0100
+++ b/OrthancFramework/Sources/Compression/ZipReader.h	Tue Dec 08 12:55:32 2020 +0100
@@ -62,8 +62,8 @@
 
     uint64_t GetFilesCount() const;
 
-    bool ReadNextFile(std::string& content,
-                      std::string& filename);
+    bool ReadNextFile(std::string& filename,
+                      std::string& content);
     
     static ZipReader* CreateFromMemory(const void* buffer,
                                        size_t size);
diff -r 460a71988208 -r 18c94a82f3d4 OrthancServer/Resources/RunCppCheck.sh
--- a/OrthancServer/Resources/RunCppCheck.sh	Tue Dec 08 12:38:59 2020 +0100
+++ b/OrthancServer/Resources/RunCppCheck.sh	Tue Dec 08 12:55:32 2020 +0100
@@ -18,7 +18,7 @@
 stlFindInsert:../../OrthancServer/Sources/OrthancWebDav.cpp:383
 stlFindInsert:../../OrthancServer/Sources/ServerIndex.cpp:400
 syntaxError:../../OrthancFramework/Sources/SQLite/FunctionContext.h:50
-syntaxError:../../OrthancFramework/UnitTestsSources/ZipTests.cpp:129
+syntaxError:../../OrthancFramework/UnitTestsSources/ZipTests.cpp:130
 syntaxError:../../OrthancServer/UnitTestsSources/UnitTestsMain.cpp:319
 uninitMemberVar:../../OrthancServer/Sources/ServerJobs/StorageCommitmentScpJob.cpp:427
 unreadVariable:../../OrthancFramework/Sources/FileStorage/StorageAccessor.cpp