# HG changeset patch # User Alain Mazy # Date 1762794505 -3600 # Node ID 002e1521458f0b9454edca6e1de8caf5a1197006 # Parent de5d2b6cdda8a9c600f962bd479f33dd87534251 cppcheck: constVariableReference diff -r de5d2b6cdda8 -r 002e1521458f OrthancFramework/Sources/JobsEngine/JobsRegistry.cpp --- a/OrthancFramework/Sources/JobsEngine/JobsRegistry.cpp Mon Nov 10 18:07:57 2025 +0100 +++ b/OrthancFramework/Sources/JobsEngine/JobsRegistry.cpp Mon Nov 10 18:08:25 2025 +0100 @@ -1597,7 +1597,7 @@ for (JobsIndex::const_iterator it = jobsIndex_.begin(); it != jobsIndex_.end(); ++it) { - JobHandler& job = *it->second; + const JobHandler& job = *it->second; switch (job.GetState()) { diff -r de5d2b6cdda8 -r 002e1521458f OrthancServer/Plugins/Engine/OrthancPlugins.cpp --- a/OrthancServer/Plugins/Engine/OrthancPlugins.cpp Mon Nov 10 18:07:57 2025 +0100 +++ b/OrthancServer/Plugins/Engine/OrthancPlugins.cpp Mon Nov 10 18:08:25 2025 +0100 @@ -5888,7 +5888,7 @@ case _OrthancPluginService_KeysValuesIteratorGetKey: { const _OrthancPluginKeysValuesIteratorGetKey& p = *reinterpret_cast(parameters); - StatelessDatabaseOperations::KeysValuesIterator& iterator = *reinterpret_cast(p.iterator); + const StatelessDatabaseOperations::KeysValuesIterator& iterator = *reinterpret_cast(p.iterator); *p.target = iterator.GetKey().c_str(); return true; } @@ -5896,7 +5896,7 @@ case _OrthancPluginService_KeysValuesIteratorGetValue: { const _OrthancPluginKeysValuesIteratorGetValue& p = *reinterpret_cast(parameters); - StatelessDatabaseOperations::KeysValuesIterator& iterator = *reinterpret_cast(p.iterator); + const StatelessDatabaseOperations::KeysValuesIterator& iterator = *reinterpret_cast(p.iterator); CopyToMemoryBuffer(p.target, iterator.GetValue()); return true; } diff -r de5d2b6cdda8 -r 002e1521458f OrthancServer/Sources/OrthancWebDav.cpp --- a/OrthancServer/Sources/OrthancWebDav.cpp Mon Nov 10 18:07:57 2025 +0100 +++ b/OrthancServer/Sources/OrthancWebDav.cpp Mon Nov 10 18:08:25 2025 +0100 @@ -1256,7 +1256,7 @@ success = true; } } - catch (OrthancException& e) + catch (const OrthancException&) { } } diff -r de5d2b6cdda8 -r 002e1521458f OrthancServer/Sources/ServerContext.cpp --- a/OrthancServer/Sources/ServerContext.cpp Mon Nov 10 18:07:57 2025 +0100 +++ b/OrthancServer/Sources/ServerContext.cpp Mon Nov 10 18:08:25 2025 +0100 @@ -1885,7 +1885,7 @@ return decoded.release(); } } - catch (OrthancException& e) + catch (const OrthancException&) { // ignore, we'll try other alternatives } } @@ -1898,7 +1898,7 @@ { decoded.reset(GetPlugins().Decode(buffer, size, frameIndex)); } - catch (OrthancException& e) + catch (const OrthancException&) { } diff -r de5d2b6cdda8 -r 002e1521458f OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp --- a/OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp Mon Nov 10 18:07:57 2025 +0100 +++ b/OrthancServer/Sources/ServerJobs/ResourceModificationJob.cpp Mon Nov 10 18:08:25 2025 +0100 @@ -185,7 +185,7 @@ for (std::set::const_iterator it = instancesToReconstruct_.begin(); it != instancesToReconstruct_.end(); ++it) { ServerContext::DicomCacheLocker locker(GetContext(), *it); - ParsedDicomFile& modifiedDicom = locker.GetDicom(); + const ParsedDicomFile& modifiedDicom = locker.GetDicom(); GetContext().GetIndex().ReconstructInstance(modifiedDicom, false, ResourceType_Instance /* dummy */); } @@ -219,7 +219,7 @@ try { ServerContext::DicomCacheLocker locker(GetContext(), instance); - ParsedDicomFile& original = locker.GetDicom(); + const ParsedDicomFile& original = locker.GetDicom(); originalHasher.reset(new DicomInstanceHasher(original.GetHasher())); modified.reset(original.Clone(true));