view OrthancServer/ServerJobs/Operations/SystemCallOperation.cpp @ 4088:ce7709cb380e

Fix issue #183 (C-ECHO always fails in Orthanc Explorer, regression from 1.6.1 to 1.7.0)
author Sebastien Jodogne <s.jodogne@gmail.com>
date Sat, 27 Jun 2020 10:48:49 +0200
parents 6498739a3c3c
children
line wrap: on
line source

/**
 * Orthanc - A Lightweight, RESTful DICOM Store
 * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics
 * Department, University Hospital of Liege, Belgium
 * Copyright (C) 2017-2020 Osimis S.A., Belgium
 *
 * This program is free software: you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * In addition, as a special exception, the copyright holders of this
 * program give permission to link the code of its release with the
 * OpenSSL project's "OpenSSL" library (or with modified versions of it
 * that use the same license as the "OpenSSL" library), and distribute
 * the linked executables. You must obey the GNU General Public License
 * in all respects for all of the code used other than "OpenSSL". If you
 * modify file(s) with this exception, you may extend this exception to
 * your version of the file(s), but you are not obligated to do so. If
 * you do not wish to do so, delete this exception statement from your
 * version. If you delete this exception statement from all source files
 * in the program, then also delete it here.
 * 
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 **/


#include "../../PrecompiledHeadersServer.h"
#include "SystemCallOperation.h"

#include "DicomInstanceOperationValue.h"

#include "../../../Core/JobsEngine/Operations/StringOperationValue.h"
#include "../../../Core/Logging.h"
#include "../../../Core/OrthancException.h"
#include "../../../Core/SerializationToolbox.h"
#include "../../../Core/TemporaryFile.h"
#include "../../../Core/Toolbox.h"
#include "../../../Core/SystemToolbox.h"
#include "../../OrthancConfiguration.h"

namespace Orthanc
{
  const std::string& SystemCallOperation::GetPreArgument(size_t i) const
  {
    if (i >= preArguments_.size())
    {
      throw OrthancException(ErrorCode_ParameterOutOfRange);
    }
    else
    {
      return preArguments_[i];
    }
  }

  
  const std::string& SystemCallOperation::GetPostArgument(size_t i) const
  {
    if (i >= postArguments_.size())
    {
      throw OrthancException(ErrorCode_ParameterOutOfRange);
    }
    else
    {
      return postArguments_[i];
    }
  }


  void SystemCallOperation::Apply(JobOperationValues& outputs,
                                  const JobOperationValue& input)
  {
    std::vector<std::string> arguments = preArguments_;

    arguments.reserve(arguments.size() + postArguments_.size() + 1);

    std::unique_ptr<TemporaryFile> tmp;
    
    switch (input.GetType())
    {
      case JobOperationValue::Type_DicomInstance:
      {
        const DicomInstanceOperationValue& instance =
          dynamic_cast<const DicomInstanceOperationValue&>(input);

        std::string dicom;
        instance.ReadDicom(dicom);

        {
          OrthancConfiguration::ReaderLock lock;
          tmp.reset(lock.GetConfiguration().CreateTemporaryFile());
        }

        tmp->Write(dicom);
        
        arguments.push_back(tmp->GetPath());
        break;
      }

      case JobOperationValue::Type_String:
      {
        const StringOperationValue& value =
          dynamic_cast<const StringOperationValue&>(input);

        arguments.push_back(value.GetContent());
        break;
      }

      case JobOperationValue::Type_Null:
        break;

      default:
        throw OrthancException(ErrorCode_BadParameterType);
    }

    for (size_t i = 0; i < postArguments_.size(); i++)
    {
      arguments.push_back(postArguments_[i]);
    }

    std::string info = command_;
    for (size_t i = 0; i < arguments.size(); i++)
    {
      info += " " + arguments[i];
    }
    
    LOG(INFO) << "Lua: System call: \"" << info << "\"";

    try
    {
      SystemToolbox::ExecuteSystemCommand(command_, arguments);

      // Only chain with other commands if this operation succeeds
      outputs.Append(input.Clone());
    }
    catch (OrthancException& e)
    {
      LOG(ERROR) << "Lua: Failed system call - \"" << info << "\": " << e.What();
    }
  }


  void SystemCallOperation::Serialize(Json::Value& result) const
  {
    result = Json::objectValue;
    result["Type"] = "SystemCall";
    result["Command"] = command_;
    SerializationToolbox::WriteArrayOfStrings(result, preArguments_, "PreArguments");
    SerializationToolbox::WriteArrayOfStrings(result, postArguments_, "PostArguments");
  }


  SystemCallOperation::SystemCallOperation(const Json::Value& serialized)
  {
    if (SerializationToolbox::ReadString(serialized, "Type") != "SystemCall")
    {
      throw OrthancException(ErrorCode_BadFileFormat);
    }

    command_ = SerializationToolbox::ReadString(serialized, "Command");
    SerializationToolbox::ReadArrayOfStrings(preArguments_, serialized, "PreArguments");
    SerializationToolbox::ReadArrayOfStrings(postArguments_, serialized, "PostArguments");
  }
}