Mercurial > hg > orthanc
view Resources/Samples/WebApplications/NodeToolbox.js @ 2248:69b0f4e8a49b
Escape multipart type parameter value in Content-Type header
## Summary
Multipart responses do not quote/escape the value of their type
parameter (the subtype) even though it always contains at least one
special character (the slash "/"), which confuses standard-compliant
HTTP clients.
## Details
The Content-Type header in HTTP is in RFC 7231, Section 3.1.1.5:
https://tools.ietf.org/html/rfc7231#section-3.1.1.5
The section defers to the media type section (3.1.1.1) for the syntax of
the media type:
https://tools.ietf.org/html/rfc7231#section-3.1.1.1
This states that a parameter value can be quoted:
parameter = token "=" ( token / quoted-string )
A parameter value that matches the token production can be transmitted
either as a token or within a quoted-string. The quoted and unquoted
values are equivalent.
Tokens are defined in RFC 7230, Section 3.2.6 (via RFC 7231, appendix
C):
https://tools.ietf.org/html/rfc7231#appendix-C
https://tools.ietf.org/html/rfc7230#section-3.2.6
Here we observe that tokens cannot contain a slash "/" character:
token = 1*tchar
tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*"
/ "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
/ DIGIT / ALPHA
; any VCHAR, except delimiters
Delimiters are chosen from the set of US-ASCII visual characters not
allowed in a token (DQUOTE and "(),/:;<=>?@[\]{}").
However, the current implementation does not quote/escape the value of
the type parameter:
multipart/related; type=application/dicom
Instead, it should be:
multipart/related; type="application/dicom"
All of this also seems to apply to the MIME Content-Type header
definition, even though it is a little different:
https://www.iana.org/assignments/message-headers
https://tools.ietf.org/html/rfc2045#section-5.1
https://tools.ietf.org/html/rfc2387
| author | Thibault Nélis <tn@osimis.io> |
|---|---|
| date | Mon, 16 Jan 2017 13:07:11 +0100 |
| parents | a3a65de1840f |
| children | 878b59270859 |
line wrap: on
line source
/** * Orthanc - A Lightweight, RESTful DICOM Store * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics * Department, University Hospital of Liege, Belgium * Copyright (C) 2017 Osimis, Belgium * * This program is free software: you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation, either version 3 of the * License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. **/ var fs = require('fs'); var http = require('http'); function ForwardGetRequest(orthanc, path, res) { var opts = orthanc; opts.path = path; opts.method = 'GET'; http.get(opts, function(response) { if (response.statusCode == 200) { response.setEncoding('utf-8'); response.on('data', function(chunk) { res.write(chunk); }); response.on('end', function() { res.end(); }); } else { console.log('Got error on GET forwarding: ' + response.statusCode + ' (' + path + ')'); res.writeHead(response.statusCode); res.end(); } }).on('error', function(e) { console.log('Unable to contact Orthanc: ' + e.message); res.writeHead(503); // Service Unavailable res.end(); }); } function ForwardPostRequest(orthanc, path, body, res) { var opts = orthanc; opts.path = path; opts.method = 'POST'; opts.headers = { 'Content-Length': body.length } var req = http.request(opts, function(response) { if (response.statusCode == 200) { response.setEncoding('utf-8'); response.on('data', function(chunk) { res.write(chunk); }); response.on('end', function() { res.end(); }); } else { console.log('Got error on POST forwarding: ' + response.statusCode + ' (' + path + ')'); res.writeHead(response.statusCode); res.end(); } }).on('error', function(e) { console.log('Unable to contact Orthanc: ' + e.message); res.writeHead(503); // Service Unavailable res.end(); }); req.write(body); req.end(); } function ServeFile(filename, res) { fs.readFile(filename, function(r, c) { res.end(c.toString()); }); } function NotFound(res) { res.writeHead(404, {'Content-Type': 'text/plain'}); res.end(); } function Redirect(path, res) { res.writeHead(301, { 'Content-Type': 'text/plain', 'Location': path }); res.end(); } String.prototype.startsWith = function(prefix) { return this.indexOf(prefix) === 0; } module.exports.ForwardGetRequest = ForwardGetRequest; module.exports.ForwardPostRequest = ForwardPostRequest; module.exports.NotFound = NotFound; module.exports.Redirect = Redirect; module.exports.ServeFile = ServeFile;
