Escape multipart type parameter value in Content-Type header ## Summary Multipart responses do not quote/escape the value of their type parameter (the subtype) even though it always contains at least one special character (the slash "/"), which confuses standard-compliant HTTP clients. ## Details The Content-Type header in HTTP is in RFC 7231, Section 3.1.1.5: https://tools.ietf.org/html/rfc7231#section-3.1.1.5 The section defers to the media type section (3.1.1.1) for the syntax of the media type: https://tools.ietf.org/html/rfc7231#section-3.1.1.1 This states that a parameter value can be quoted: parameter = token "=" ( token / quoted-string ) A parameter value that matches the token production can be transmitted either as a token or within a quoted-string. The quoted and unquoted values are equivalent. Tokens are defined in RFC 7230, Section 3.2.6 (via RFC 7231, appendix C): https://tools.ietf.org/html/rfc7231#appendix-C https://tools.ietf.org/html/rfc7230#section-3.2.6 Here we observe that tokens cannot contain a slash "/" character: token = 1*tchar tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*" / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~" / DIGIT / ALPHA ; any VCHAR, except delimiters Delimiters are chosen from the set of US-ASCII visual characters not allowed in a token (DQUOTE and "(),/:;<=>?@[\]{}"). However, the current implementation does not quote/escape the value of the type parameter: multipart/related; type=application/dicom Instead, it should be: multipart/related; type="application/dicom" All of this also seems to apply to the MIME Content-Type header definition, even though it is a little different: https://www.iana.org/assignments/message-headers https://tools.ietf.org/html/rfc2045#section-5.1 https://tools.ietf.org/html/rfc2387

function Initialize()
   print('Number of stored studies at initialization: ' ..
            table.getn(ParseJson(RestApiGet('/studies'))))
end


function Finalize()
   print('Number of stored studies at finalization: ' ..
            table.getn(ParseJson(RestApiGet('/studies'))))
end


function OnStoredInstance(instanceId, tags, metadata)
   patient = ParseJson(RestApiGet('/instances/' .. instanceId .. '/patient'))
   print('Received an instance for patient: ' .. 
            patient['MainDicomTags']['PatientID'] .. ' - ' .. 
            patient['MainDicomTags']['PatientName'])
end


function OnStableStudy(studyId, tags, metadata)
   if (metadata['ModifiedFrom'] == nil and
       metadata['AnonymizedFrom'] == nil) then

      print('This study is now stable: ' .. studyId)
      
      -- The tags to be replaced
      local replace = {}
      replace['StudyDescription'] = 'Modified study'
      replace['StationName'] = 'My Medical Device'
      replace['0031-1020'] = 'Some private tag'

      -- The tags to be removed
      local remove = { 'MilitaryRank' }

      -- The modification command
      local command = {}
      command['Remove'] = remove
      command['Replace'] = replace

      -- Modify the entire study in one single call
      local m = RestApiPost('/studies/' .. studyId .. '/modify',
                            DumpJson(command))
      print('Modified study: ' .. m)
   end
end