view Resources/Samples/Lua/ModifyInstanceWithSequence.lua @ 2248:69b0f4e8a49b

Escape multipart type parameter value in Content-Type header ## Summary Multipart responses do not quote/escape the value of their type parameter (the subtype) even though it always contains at least one special character (the slash "/"), which confuses standard-compliant HTTP clients. ## Details The Content-Type header in HTTP is in RFC 7231, Section 3.1.1.5: https://tools.ietf.org/html/rfc7231#section-3.1.1.5 The section defers to the media type section (3.1.1.1) for the syntax of the media type: https://tools.ietf.org/html/rfc7231#section-3.1.1.1 This states that a parameter value can be quoted: parameter = token "=" ( token / quoted-string ) A parameter value that matches the token production can be transmitted either as a token or within a quoted-string. The quoted and unquoted values are equivalent. Tokens are defined in RFC 7230, Section 3.2.6 (via RFC 7231, appendix C): https://tools.ietf.org/html/rfc7231#appendix-C https://tools.ietf.org/html/rfc7230#section-3.2.6 Here we observe that tokens cannot contain a slash "/" character: token = 1*tchar tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*" / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~" / DIGIT / ALPHA ; any VCHAR, except delimiters Delimiters are chosen from the set of US-ASCII visual characters not allowed in a token (DQUOTE and "(),/:;<=>?@[\]{}"). However, the current implementation does not quote/escape the value of the type parameter: multipart/related; type=application/dicom Instead, it should be: multipart/related; type="application/dicom" All of this also seems to apply to the MIME Content-Type header definition, even though it is a little different: https://www.iana.org/assignments/message-headers https://tools.ietf.org/html/rfc2045#section-5.1 https://tools.ietf.org/html/rfc2387
author Thibault Nélis <tn@osimis.io>
date Mon, 16 Jan 2017 13:07:11 +0100
parents 8ca0e89798b2
children 38c7bf2e10f6
line wrap: on
line source

-- Answer to:
-- https://groups.google.com/d/msg/orthanc-users/0ymHe1cDBCQ/YfD0NoOTn0wJ
-- Applicable starting with Orthanc 0.9.5

function OnStoredInstance(instanceId, tags, metadata, origin)
   -- Do not modify twice the same file
   if origin['RequestOrigin'] ~= 'Lua' then
      local replace = {}
      replace['0010,1002'] = {}
      replace['0010,1002'][1] = {}
      replace['0010,1002'][1]['PatientID'] = 'Hello'
      replace['0010,1002'][2] = {}
      replace['0010,1002'][2]['PatientID'] = 'World'

      local request = {}
      request['Replace'] = replace

      -- Create the modified instance
      local modified = RestApiPost('/instances/' .. instanceId .. '/modify',
                                   DumpJson(request))

      -- Upload the modified instance to the Orthanc store
      RestApiPost('/instances/', modified)

      -- Delete the original instance
      RestApiDelete('/instances/' .. instanceId)
   end
end